NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2119b52

Thomas G. Lockhart

committed

Fix numeric comparision (... != NULL) to be (... > 0). gcc is happier now.

Add non-working code which is commented-out to copy GroupClause structures.

1 parent12d5c30 commit2119b52Copy full SHA for 2119b52

File tree

1 file changed

+20

-2

lines changed

src/backend/nodes
- copyfuncs.c

1 file changed

+20

-2

lines changed

`‎src/backend/nodes/copyfuncs.c`

Lines changed: 20 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.22 1997/12/18 19:46:37 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.23 1997/12/23 19:53:30 thomas Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1466,6 +1466,19 @@ _copySortClause(SortClause *from)`
`1466`	`1466`	`returnnewnode;`
`1467`	`1467`	`}`
`1468`	`1468`
	`1469`	`+#ifFALSE`
	`1470`	`+staticGroupClause*`
	`1471`	`+_copyGroupClause(GroupClause*from)`
	`1472`	`+{`
	`1473`	`+GroupClause*newnode=makeNode(GroupClause);`
	`1474`	`+`
	`1475`	`+Node_Copy(from,newnode,resdom);`
	`1476`	`+newnode->opoid=from->opoid;`
	`1477`	`+`
	`1478`	`+returnnewnode;`
	`1479`	`+}`
	`1480`	`+#endif`
	`1481`	`+`
`1469`	`1482`	`staticA_Const*`
`1470`	`1483`	`_copyAConst(A_Const*from)`
`1471`	`1484`	`{`
`@@ -1542,7 +1555,7 @@ _copyQuery(Query *from)`
`1542`	`1555`	`Node_Copy(from,newnode,havingQual);/* currently ignored */`
`1543`	`1556`
`1544`	`1557`	`newnode->qry_numAgg=from->qry_numAgg;`
`1545`		`-if (from->qry_numAgg!=NULL)`
	`1558`	`+if (from->qry_numAgg>0)`
`1546`	`1559`	`{`
`1547`	`1560`	`newnode->qry_aggs=`
`1548`	`1561`	`(Aggreg*)palloc(sizeof(Aggreg)*from->qry_numAgg);`
`@@ -1763,6 +1776,11 @@ copyObject(void *from)`
`1763`	`1776`	`caseT_SortClause:`
`1764`	`1777`	`retval=_copySortClause(from);`
`1765`	`1778`	`break;`
	`1779`	`+#ifFALSE`
	`1780`	`+caseT_GroupClause:`
	`1781`	`+retval=_copyGroupClause(from);`
	`1782`	`+break;`
	`1783`	`+#endif`
`1766`	`1784`	`caseT_A_Const:`
`1767`	`1785`	`retval=_copyAConst(from);`
`1768`	`1786`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2119b52

File tree

1 file changed

1 file changed

`‎src/backend/nodes/copyfuncs.c`

0 commit comments