Commit20661c1

committed

Initialize t_self and t_tableOid in statext_expressions_load

The function is building a fake heap tuple, but left some of the headerfields (tid and table OID) uninitialized. Per Coverity report.Reported-by: Ranier VilelaDiscussion:https://postgr.es/m/CAEudQApj6h8tZ0-eP5Af5PKc5NG1YUc7=SdN_99YoHS51fKa0Q@mail.gmail.com

1 parent60f1f09 commit20661c1Copy full SHA for 20661c1

File tree

-0

lines changed

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2420,6 +2420,8 @@ statext_expressions_load(Oid stxoid, int idx)`
`2420`	`2420`
`2421`	`2421`	`/* Build a temporary HeapTuple control structure */`
`2422`	`2422`	`tmptup.t_len=HeapTupleHeaderGetDatumLength(td);`
	`2423`	`+ItemPointerSetInvalid(&(tmptup.t_self));`
	`2424`	`+tmptup.t_tableOid=InvalidOid;`
`2423`	`2425`	`tmptup.t_data=td;`
`2424`	`2426`
`2425`	`2427`	`tup=heap_copytuple(&tmptup);`

Comments

(0)