NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1fdab4d

committed

Clean up sloppy maintenance of regression test schedule files.

The partition_join test was added to a parallel group that was alreadyat the maximum of 20 concurrent tests. The hash_func test wasn'tadded to serial_schedule at all. The identity and partition_join testswere added to serial_schedule with the aid of a dartboard, rather thanmaintaining consistency with parallel_schedule.There are proposals afoot to make these sorts of errors harder to make,but in the meantime let's fix the ones already in place.Discussion:https://postgr.es/m/a37e9c57-22d4-1b82-1270-4501cd2e984e@2ndquadrant.com

1 parent1518d07 commit1fdab4dCopy full SHA for 1fdab4d

File tree

2 files changed

-4

lines changed

src/test/regress
- parallel_schedule
- serial_schedule

2 files changed

-4

lines changed

`‎src/test/regress/parallel_schedule`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ test: publication subscription`
`104`	`104`	`# ----------`
`105`	`105`	`# Another group of parallel tests`
`106`	`106`	`# ----------`
`107`		`-test: select_views portals_p2 foreign_key cluster dependency guc bitmapops combocid tsearch tsdicts foreign_data window xmlmap functional_deps advisory_lock json jsonb json_encoding indirect_toast equivclass partition_join`
	`107`	`+test: select_views portals_p2 foreign_key cluster dependency guc bitmapops combocid tsearch tsdicts foreign_data window xmlmap functional_deps advisory_lock json jsonb json_encoding indirect_toast equivclass`
`108`	`108`
`109`	`109`	`# ----------`
`110`	`110`	`# Another group of parallel tests`
`@@ -116,7 +116,7 @@ test: plancache limit plpgsql copy2 temp domain rangefuncs prepare without_oid c`
`116`	`116`	`# ----------`
`117`	`117`	`# Another group of parallel tests`
`118`	`118`	`# ----------`
`119`		`-test: identity`
	`119`	`+test: identity partition_join`
`120`	`120`
`121`	`121`	`# event triggers cannot run concurrently with any test that runs DDL`
`122`	`122`	`test: event_trigger`

`‎src/test/regress/serial_schedule`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ test: updatable_views`
`79`	`79`	`test: rolenames`
`80`	`80`	`test: roleattributes`
`81`	`81`	`test: create_am`
	`82`	`+test: hash_func`
`82`	`83`	`test: sanity_check`
`83`	`84`	`test: errors`
`84`	`85`	`test: select`
`@@ -171,13 +172,13 @@ test: conversion`
`171`	`172`	`test: truncate`
`172`	`173`	`test: alter_table`
`173`	`174`	`test: sequence`
`174`		`-test: identity`
`175`	`175`	`test: polymorphism`
`176`	`176`	`test: rowtypes`
`177`	`177`	`test: returning`
`178`	`178`	`test: largeobject`
`179`	`179`	`test: with`
`180`	`180`	`test: xml`
	`181`	`+test: identity`
	`182`	`+test: partition_join`
`181`	`183`	`test: event_trigger`
`182`	`184`	`test: stats`
`183`		`-test: partition_join`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1fdab4d

File tree

2 files changed

2 files changed

`‎src/test/regress/parallel_schedule`

`‎src/test/regress/serial_schedule`

0 commit comments