NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1fcf62e

committed

Handle lack of DSM slots in parallel btree build.

If no DSM slots are available, a ParallelContext can still becreated, but its seg pointer is NULL. Teach parallel btree buildto cope with that by falling back to a regular non-parallel build,to avoid crashing with a segmentation fault.Back-patch to 11, where parallel CREATE INDEX landed.Reported-by: Nicola ContuReviewed-by: Peter GeogheganDiscussion:https://postgr.es/m/CA%2BhUKGJgJEBnkuODBVomyK3MWFvDBbMVj%3Dgdt6DnRPU-5sQ6UQ%40mail.gmail.com

1 parentde01777 commit1fcf62eCopy full SHA for 1fcf62e

File tree

1 file changed

-0

lines changed

src/backend/access/nbtree
- nbtsort.c

1 file changed

-0

lines changed

`‎src/backend/access/nbtree/nbtsort.c`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1352,6 +1352,15 @@ _bt_begin_parallel(BTBuildState *buildstate, bool isconcurrent, int request)`
`1352`	`1352`	`Assert(request>0);`
`1353`	`1353`	`pcxt=CreateParallelContext("postgres","_bt_parallel_build_main",`
`1354`	`1354`	`request);`
	`1355`	`+`
	`1356`	`+/* If no DSM segment was available, back out (do serial build) */`
	`1357`	`+if (pcxt->seg==NULL)`
	`1358`	`+{`
	`1359`	`+DestroyParallelContext(pcxt);`
	`1360`	`+ExitParallelMode();`
	`1361`	`+return;`
	`1362`	`+}`
	`1363`	`+`
`1355`	`1364`	`scantuplesortstates=leaderparticipates ?request+1 :request;`
`1356`	`1365`
`1357`	`1366`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1fcf62e

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtsort.c`

0 commit comments