NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1f7452f

committed

Remove COMMAND_TAG_NEXTTAG from enum CommandTag.

COMMAND_TAG_NEXTTAG isn't really a valid command tag. Declaring itas if it were one prompts complaints from Coverity and perhaps otherstatic analyzers. Our only use of it is in an entirely-unnecessaryarray sizing declaration, so let's just drop it.Ranier VilelaDiscussion:https://postgr.es/m/CAEudQAoY0xrKuTAX7W10zsjjUpKBPFRtdCyScb3Z0FB2v6HNmQ@mail.gmail.com

1 parent11c1984 commit1f7452fCopy full SHA for 1f7452f

File tree

2 files changed

-2

lines changed

src
- backend/tcop
  - cmdtag.c
- include/tcop
  - cmdtag.h

2 files changed

-2

lines changed

`‎src/backend/tcop/cmdtag.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ typedef struct CommandTagBehavior`
`30`	`30`	`#definePG_CMDTAG(tag,name,evtrgok,rwrok,rowcnt) \`
`31`	`31`	`{ name, (uint8) (sizeof(name) - 1), evtrgok, rwrok, rowcnt },`
`32`	`32`
`33`		`-staticconstCommandTagBehaviortag_behavior[COMMAND_TAG_NEXTTAG]= {`
	`33`	`+staticconstCommandTagBehaviortag_behavior[]= {`
`34`	`34`	`#include"tcop/cmdtaglist.h"`
`35`	`35`	`};`
`36`	`36`

`‎src/include/tcop/cmdtag.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@`
`22`	`22`	`typedefenumCommandTag`
`23`	`23`	`{`
`24`	`24`	`#include "tcop/cmdtaglist.h"`
`25`		`-COMMAND_TAG_NEXTTAG`
`26`	`25`	`}CommandTag;`
`27`	`26`
`28`	`27`	`#undef PG_CMDTAG`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1f7452f

File tree

2 files changed

2 files changed

`‎src/backend/tcop/cmdtag.c`

`‎src/include/tcop/cmdtag.h`

0 commit comments