Commit1f4eb73

committed

Fix EXPLAIN Bitmap heap scan to count pages with no visible tuples

Previously, bitmap heap scans only counted lossy and exact pages forexplain when there was at least one visible tuple on the page.heapam_scan_bitmap_next_block() returned true only if there was a"valid" page with tuples to be processed. However, the lossy and exactpage counters in EXPLAIN should count the number of pages representedin a lossy or non-lossy way in the constructed bitmap, regardless ofwhether or not the pages ultimately contained visible tuples.Backpatch to all supported versions.Author: Melanie PlagemanDiscussion:https://www.postgresql.org/message-id/CAAKRu_ZwCwWFeL_H3ia26bP2e7HiKLWt0ZmGXPVwPO6uXq0vaA@mail.gmail.comDiscussion:https://www.postgresql.org/message-id/CAAKRu_bxrXeZ2rCnY8LyeC2Ls88KpjWrQ%2BopUrXDRXdcfwFZGA@mail.gmail.com

1 parent34c854b commit1f4eb73Copy full SHA for 1f4eb73

File tree

-6

lines changed

src
- backend/executor
  - nodeBitmapHeapscan.c
- test/regress/expected
  - partition_prune.out

-6

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -207,6 +207,11 @@ BitmapHeapNext(BitmapHeapScanState *node)`
`207`	`207`
`208`	`208`	`BitmapAdjustPrefetchIterator(node,tbmres);`
`209`	`209`
	`210`	`+if (tbmres->ntuples >=0)`
	`211`	`+node->exact_pages++;`
	`212`	`+else`
	`213`	`+node->lossy_pages++;`
	`214`	`+`
`210`	`215`	`/*`
`211`	`216`	`* We can skip fetching the heap page if we don't need any fields`
`212`	`217`	`* from the heap, and the bitmap entries don't need rechecking,`
`@@ -238,11 +243,6 @@ BitmapHeapNext(BitmapHeapScanState *node)`
`238`	`243`	`continue;`
`239`	`244`	`}`
`240`	`245`
`241`		`-if (tbmres->ntuples >=0)`
`242`		`-node->exact_pages++;`
`243`		`-else`
`244`		`-node->lossy_pages++;`
`245`		`-`
`246`	`246`	`/* Adjust the prefetch target */`
`247`	`247`	`BitmapAdjustPrefetchTarget(node);`
`248`	`248`	`}`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2812,6 +2812,7 @@ update ab_a1 set b = 3 from ab where ab.a = 1 and ab.a = ab_a1.a;`
`2812`	`2812`	`Index Cond: (a = 1)`
`2813`	`2813`	`-> Bitmap Heap Scan on ab_a1_b3 ab_a1_3 (actual rows=0 loops=1)`
`2814`	`2814`	`Recheck Cond: (a = 1)`
	`2815`	`+ Heap Blocks: exact=1`
`2815`	`2816`	`-> Bitmap Index Scan on ab_a1_b3_a_idx (actual rows=1 loops=1)`
`2816`	`2817`	`Index Cond: (a = 1)`
`2817`	`2818`	`-> Materialize (actual rows=1 loops=1)`
`@@ -2827,9 +2828,10 @@ update ab_a1 set b = 3 from ab where ab.a = 1 and ab.a = ab_a1.a;`
`2827`	`2828`	`Index Cond: (a = 1)`
`2828`	`2829`	`-> Bitmap Heap Scan on ab_a1_b3 ab_3 (actual rows=0 loops=1)`
`2829`	`2830`	`Recheck Cond: (a = 1)`
	`2831`	`+ Heap Blocks: exact=1`
`2830`	`2832`	`-> Bitmap Index Scan on ab_a1_b3_a_idx (actual rows=1 loops=1)`
`2831`	`2833`	`Index Cond: (a = 1)`
`2832`		`-(34 rows)`
	`2834`	`+(36 rows)`
`2833`	`2835`
`2834`	`2836`	`table ab;`
`2835`	`2837`	`a \| b`

Comments

(0)