NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1f303fd

committed

Suppress occasional failures in brin regression test.

brin.sql included a call of brin_summarize_new_values(), and expectedit to always report exactly 5 summarization events. This failed sometimesduring parallel regression tests, as a consequence of the database-wideVACUUM in gist.sql getting there first. The most future-proof wayto avoid variation in the test results is to forget about usingbrin_summarize_new_values() and just do a plain "VACUUM brintest",which will exercise the same code anyway.Having done that, there's no need for preventing autovacuum on brintest;doing so just reduces the scope of test coverage, so let's not.

1 parentfba12c8 commit1f303fdCopy full SHA for 1f303fd

File tree

2 files changed

-9

lines changed

src/test/regress
- expected
  - brin.out
- sql
  - brin.sql

2 files changed

-9

lines changed

`‎src/test/regress/expected/brin.out`

Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ CREATE TABLE brintest (byteacol bytea,`
`26`	`26`	`int4rangecol int4range,`
`27`	`27`	`lsncol pg_lsn,`
`28`	`28`	`boxcol box`
`29`		`-) WITH (fillfactor=10, autovacuum_enabled=off);`
	`29`	`+) WITH (fillfactor=10);`
`30`	`30`	`INSERT INTO brintest SELECT`
`31`	`31`	`repeat(stringu1, 8)::bytea,`
`32`	`32`	`substr(stringu1, 1, 1)::"char",`
`@@ -239,11 +239,6 @@ INSERT INTO brintest SELECT`
`239`	`239`	`format('%s/%s%s', odd, even, tenthous)::pg_lsn,`
`240`	`240`	`box(point(odd, even), point(thousand, twothousand))`
`241`	`241`	`FROM tenk1 LIMIT 5 OFFSET 5;`
`242`		`-SELECT brin_summarize_new_values('brinidx'::regclass);`
`243`		`- brin_summarize_new_values`
`244`		`----------------------------`
`245`		`- 5`
`246`		`-(1 row)`
`247`		`-`
	`242`	`+VACUUM brintest; -- force a summarization cycle in brinidx`
`248`	`243`	`UPDATE brintest SET int8col = int8col * int4col;`
`249`	`244`	`UPDATE brintest SET textcol = '' WHERE textcol IS NOT NULL;`

`‎src/test/regress/sql/brin.sql`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ CREATE TABLE brintest (byteacol bytea,`
`26`	`26`	`int4rangecol int4range,`
`27`	`27`	`lsncol pg_lsn,`
`28`	`28`	`boxcolbox`
`29`		`-) WITH (fillfactor=10, autovacuum_enabled=off);`
	`29`	`+) WITH (fillfactor=10);`
`30`	`30`
`31`	`31`	`INSERT INTO brintestSELECT`
`32`	`32`	`repeat(stringu1,8)::bytea,`
`@@ -247,7 +247,7 @@ INSERT INTO brintest SELECT`
`247`	`247`	`box(point(odd, even),point(thousand, twothousand))`
`248`	`248`	`FROM tenk1LIMIT5 OFFSET5;`
`249`	`249`
`250`		`-SELECT brin_summarize_new_values('brinidx'::regclass);`
	`250`	`+VACUUM brintest;-- force a summarization cycle in brinidx`
`251`	`251`
`252`	`252`	`UPDATE brintestSET int8col= int8col* int4col;`
`253`	`253`	`UPDATE brintestSET textcol=''WHERE textcolIS NOT NULL;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1f303fd

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/brin.out`

`‎src/test/regress/sql/brin.sql`

0 commit comments