Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1ef61dd

Browse files
committed
Fix StoreCatalogInheritance1 to use 32bit inhseqno
For no apparent reason, this function was using a 16bit-wide inhseqnovalue, rather than the correct 32 bit width which is what is stored inthe pg_inherits catalog. This becomes evident if you try to create atable with more than 65535 parents, because this error appears:ERROR: duplicate key value violates unique constraint «pg_inherits_relid_seqno_index»DETAIL: Key (inhrelid, inhseqno)=(329371, 0) already exists.Needless to say, having so many parents is an uncommon situations, whichexplains why this error has never been reported despite being havingbeen introduced with the Postgres95 1.01 sources in commitd31084e:https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/commands/creatinh.c;hb=d31084e9d111#l349Backpatch all the way back.David Rowley noticed this while reviewing a patch of mine.Discussion:https://postgr.es/m/CAKJS1f8Dn7swSEhOWwzZzssW7747YB=2Hi+T7uGud40dur69-g@mail.gmail.com
1 parent29d58fd commit1ef61dd

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎src/backend/commands/tablecmds.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ static void MergeConstraintsIntoExisting(Relation child_rel, Relation parent_rel
303303
staticvoidStoreCatalogInheritance(OidrelationId,List*supers,
304304
boolchild_is_partition);
305305
staticvoidStoreCatalogInheritance1(OidrelationId,OidparentOid,
306-
int16seqNumber,RelationinhRelation,
306+
int32seqNumber,RelationinhRelation,
307307
boolchild_is_partition);
308308
staticintfindAttrByName(constchar*attributeName,List*schema);
309309
staticvoidAlterIndexNamespaces(RelationclassRel,Relationrel,
@@ -2352,7 +2352,7 @@ StoreCatalogInheritance(Oid relationId, List *supers,
23522352
boolchild_is_partition)
23532353
{
23542354
Relationrelation;
2355-
int16seqNumber;
2355+
int32seqNumber;
23562356
ListCell*entry;
23572357

23582358
/*
@@ -2393,7 +2393,7 @@ StoreCatalogInheritance(Oid relationId, List *supers,
23932393
*/
23942394
staticvoid
23952395
StoreCatalogInheritance1(OidrelationId,OidparentOid,
2396-
int16seqNumber,RelationinhRelation,
2396+
int32seqNumber,RelationinhRelation,
23972397
boolchild_is_partition)
23982398
{
23992399
TupleDescdesc=RelationGetDescr(inhRelation);
@@ -2408,7 +2408,7 @@ StoreCatalogInheritance1(Oid relationId, Oid parentOid,
24082408
*/
24092409
values[Anum_pg_inherits_inhrelid-1]=ObjectIdGetDatum(relationId);
24102410
values[Anum_pg_inherits_inhparent-1]=ObjectIdGetDatum(parentOid);
2411-
values[Anum_pg_inherits_inhseqno-1]=Int16GetDatum(seqNumber);
2411+
values[Anum_pg_inherits_inhseqno-1]=Int32GetDatum(seqNumber);
24122412

24132413
memset(nulls,0,sizeof(nulls));
24142414

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp