NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1ed1f80

committed

Ensure that slots are zeroed before use

The previous coding relied on the memory for the slots being zeroedelsewhere, which while it was true in this case is not an contractwhich is guaranteed to hold. Explicitly clear the tts_isnull arrayto ensure that the slots are filled from a known state.Backpatch to v14 where the catalog multi-inserts were introduced.Reviewed-by: Michael Paquier <michael@paquier.xyz>Discussion:https://postgr.es/m/CAJ7c6TP0AowkUgNL6zcAK-s5HYsVHVBRWfu69FRubPpfwZGM9A@mail.gmail.comBackpatch-through: 14

1 parenta6a0ae1 commit1ed1f80Copy full SHA for 1ed1f80

File tree

2 files changed

-0

lines changed

src/backend/catalog
- heap.c
- pg_shdepend.c

2 files changed

-0

lines changed

`‎src/backend/catalog/heap.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -766,6 +766,9 @@ InsertPgAttributeTuples(Relation pg_attribute_rel,`
`766`	`766`
`767`	`767`	`ExecClearTuple(slot[slotCount]);`
`768`	`768`
	`769`	`+memset(slot[slotCount]->tts_isnull, false,`
	`770`	`+slot[slotCount]->tts_tupleDescriptor->natts*sizeof(bool));`
	`771`	`+`
`769`	`772`	`if (new_rel_oid!=InvalidOid)`
`770`	`773`	`slot[slotCount]->tts_values[Anum_pg_attribute_attrelid-1]=ObjectIdGetDatum(new_rel_oid);`
`771`	`774`	`else`

`‎src/backend/catalog/pg_shdepend.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -907,6 +907,9 @@ copyTemplateDependencies(Oid templateDbId, Oid newDbId)`
`907`	`907`
`908`	`908`	`ExecClearTuple(slot[slot_stored_count]);`
`909`	`909`
	`910`	`+memset(slot[slot_stored_count]->tts_isnull, false,`
	`911`	`+slot[slot_stored_count]->tts_tupleDescriptor->natts*sizeof(bool));`
	`912`	`+`
`910`	`913`	`shdep= (Form_pg_shdepend)GETSTRUCT(tup);`
`911`	`914`
`912`	`915`	`slot[slot_stored_count]->tts_values[Anum_pg_shdepend_dbid-1]=ObjectIdGetDatum(newDbId);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1ed1f80

File tree

2 files changed

2 files changed

`‎src/backend/catalog/heap.c`

`‎src/backend/catalog/pg_shdepend.c`

0 commit comments