forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit1e942c7
committed
Disable prompting for passphrase while (re)loading SSL config files.
OpenSSL's default behavior when loading a passphrase-protected key fileis to open /dev/tty and demand the password from there. It was kindasorta okay to allow that to happen at server start, but really that wasnever workable in standard daemon environments. And it was a completefail on Windows, where the same thing would happen at every backend launch.Yesterday's commitde41869 put the final nail in the coffin by causingthat to happen at every SIGHUP; even if you've still got a terminal actingas the server's TTY, having the postmaster freeze until you enter thepassphrase again isn't acceptable.Hence, override the default behavior with a callback that returns an emptystring, ensuring failure. Change the documentation to say that you can'thave a passphrase-protected server key, period.If we can think of a production-grade way of collecting a passphrase fromsomewhere, we might do that once at server startup and use this callbackto feed it to OpenSSL, but it's far from clear that anyone cares enoughto invest that much work in the feature. The lack of complaints aboutthe existing fractionally-baked behavior suggests nobody's using it anyway.Discussion:https://postgr.es/m/29982.1483412575@sss.pgh.pa.us1 parent3d54c16 commit1e942c7
File tree
2 files changed
+33
-5
lines changed- doc/src/sgml
- src/backend/libpq
2 files changed
+33
-5
lines changedLines changed: 4 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2159 | 2159 |
| |
2160 | 2160 |
| |
2161 | 2161 |
| |
2162 |
| - | |
2163 |
| - | |
2164 |
| - | |
| 2162 | + | |
| 2163 | + | |
2165 | 2164 |
| |
2166 | 2165 |
| |
2167 | 2166 |
| |
| |||
2315 | 2314 |
| |
2316 | 2315 |
| |
2317 | 2316 |
| |
2318 |
| - | |
2319 |
| - | |
| 2317 | + | |
| 2318 | + | |
2320 | 2319 |
| |
2321 | 2320 |
| |
2322 | 2321 |
| |
|
Lines changed: 29 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
75 | 75 |
| |
76 | 76 |
| |
77 | 77 |
| |
| 78 | + | |
78 | 79 |
| |
79 | 80 |
| |
80 | 81 |
| |
| |||
203 | 204 |
| |
204 | 205 |
| |
205 | 206 |
| |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
206 | 212 |
| |
207 | 213 |
| |
208 | 214 |
| |
| |||
1060 | 1066 |
| |
1061 | 1067 |
| |
1062 | 1068 |
| |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
1063 | 1092 |
| |
1064 | 1093 |
| |
1065 | 1094 |
| |
|
0 commit comments
Comments
(0)