NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1e9326d

committed

Fix statistics breakage from bgwriter/checkpointer process split.

ForwardFsyncRequest() supposed that it could only be called in regularbackends, which used to be true; but since the splitup of bgwriter andcheckpointer, it is also called in the bgwriter. We do not want to countsuch calls in pg_stat_bgwriter.buffers_backend statistics, so fix thingsso that they aren't.(It's worth noting here that this implies an alarmingly large increase inthe expected amount of cross-process fsync request traffic, which may wellmean that the process splitup was not such a hot idea.)

1 parentd843589 commit1e9326dCopy full SHA for 1e9326d

File tree

1 file changed

-2

lines changed

src/backend/postmaster
- checkpointer.c

1 file changed

-2

lines changed

`‎src/backend/postmaster/checkpointer.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1135,7 +1135,8 @@ ForwardFsyncRequest(RelFileNode rnode, ForkNumber forknum, BlockNumber segno)`
`1135`	`1135`	`LWLockAcquire(CheckpointerCommLock,LW_EXCLUSIVE);`
`1136`	`1136`
`1137`	`1137`	`/* Count all backend writes regardless of if they fit in the queue */`
`1138`		`-CheckpointerShmem->num_backend_writes++;`
	`1138`	`+if (!AmBackgroundWriterProcess())`
	`1139`	`+CheckpointerShmem->num_backend_writes++;`
`1139`	`1140`
`1140`	`1141`	`/*`
`1141`	`1142`	`* If the checkpointer isn't running or the request queue is full, the`
`@@ -1150,7 +1151,8 @@ ForwardFsyncRequest(RelFileNode rnode, ForkNumber forknum, BlockNumber segno)`
`1150`	`1151`	`* Count the subset of writes where backends have to do their own`
`1151`	`1152`	`* fsync`
`1152`	`1153`	`*/`
`1153`		`-CheckpointerShmem->num_backend_fsync++;`
	`1154`	`+if (!AmBackgroundWriterProcess())`
	`1155`	`+CheckpointerShmem->num_backend_fsync++;`
`1154`	`1156`	`LWLockRelease(CheckpointerCommLock);`
`1155`	`1157`	`return false;`
`1156`	`1158`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1e9326d

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/checkpointer.c`

0 commit comments