NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1e78d81

committed

Don't open a WAL segment for writing at end of recovery.

Since commitba94518, we used XLogFileOpen to open the next segment forwriting, but if the end-of-recovery happens exactly at a segment boundary,the new segment might not exist yet. (Beforeba94518, XLogFileOpen wascorrect, because we would open the previous segment if the switch happenedat the boundary.)Instead of trying to create it if necessary, it's simpler to not botheropening the segment at all. XLogWrite() will open or create it soon anyway,after writing the checkpoint or end-of-recovery record.Reported by Andres Freund.

1 parent79af9a1 commit1e78d81Copy full SHA for 1e78d81

File tree

1 file changed

-5

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-5

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -5646,7 +5646,6 @@ StartupXLOG(void)`
`5646`	`5646`	`XLogRecPtrRecPtr,`
`5647`	`5647`	`checkPointLoc,`
`5648`	`5648`	`EndOfLog;`
`5649`		`-XLogSegNostartLogSegNo;`
`5650`	`5649`	`TimeLineIDPrevTimeLineID;`
`5651`	`5650`	`XLogRecord*record;`
`5652`	`5651`	`TransactionIdoldestActiveXID;`
`@@ -6633,7 +6632,6 @@ StartupXLOG(void)`
`6633`	`6632`	`*/`
`6634`	`6633`	`record=ReadRecord(xlogreader,LastRec,PANIC, false);`
`6635`	`6634`	`EndOfLog=EndRecPtr;`
`6636`		`-XLByteToSeg(EndOfLog,startLogSegNo);`
`6637`	`6635`
`6638`	`6636`	`/*`
`6639`	`6637`	`* Complain if we did not roll forward far enough to render the backup`
`@@ -6741,9 +6739,6 @@ StartupXLOG(void)`
`6741`	`6739`	`* buffer cache using the block containing the last record from the`
`6742`	`6740`	`* previous incarnation.`
`6743`	`6741`	`*/`
`6744`		`-openLogSegNo=startLogSegNo;`
`6745`		`-openLogFile=XLogFileOpen(openLogSegNo);`
`6746`		`-openLogOff=0;`
`6747`	`6742`	`Insert=&XLogCtl->Insert;`
`6748`	`6743`	`Insert->PrevBytePos=XLogRecPtrToBytePos(LastRec);`
`6749`	`6744`	`Insert->CurrBytePos=XLogRecPtrToBytePos(EndOfLog);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1e78d81

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments