NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1e6e404

committed

Fix recovery test hang in 021_row_visibility.pl on windows.

The psql processes were not explicitly killed (but would eventuallyexit due postgres shutting down). For some reason windows perl doesn'tlike that, resulting in errors likeWarning: unable to close filehandle GEN20 properly: Bad file descriptor during global destruction.The test was introduced in d6734a897e3, so no backpatching necessary.

1 parentf5a5773 commit1e6e404Copy full SHA for 1e6e404

File tree

1 file changed

-0

lines changed

src/test/recovery/t
- 021_row_visibility.pl

1 file changed

-0

lines changed

`‎src/test/recovery/t/021_row_visibility.pl`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,10 @@`
`151`	`151`	`qr/will_commit.*\n$1 row$$/m),`
`152`	`152`	`'finished prepared visible');`
`153`	`153`
	`154`	`+# explicitly shut down psql instances - they cause hangs on windows`
	`155`	`+$psql_primary{run}->kill_kill;`
	`156`	`+$psql_standby{run}->kill_kill;`
	`157`	`+`
`154`	`158`	`$node_primary->stop;`
`155`	`159`	`$node_standby->stop;`
`156`	`160`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1e6e404

File tree

1 file changed

1 file changed

`‎src/test/recovery/t/021_row_visibility.pl`

0 commit comments