Commit1e2fddf

committed

Handle fsync failures in pg_receivewal and pg_recvlogical

It is not safe to simply report an fsync error and continue. We mustexit the program instead.Reviewed-by: Michael Paquier <michael@paquier.xyz>Reviewed-by: Sehrope Sarkuni <sehrope@jackdb.com>Discussion:https://www.postgresql.org/message-id/flat/9b49fe44-8f3e-eca9-5914-29e9e99030bf@2ndquadrant.com

1 parenteb43f3d commit1e2fddfCopy full SHA for 1e2fddf

File tree

-9

lines changed

-9

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -192,8 +192,8 @@ OutputFsync(TimestampTz now)`
`192`	`192`
`193`	`193`	`if (fsync(outfd)!=0)`
`194`	`194`	`{`
`195`		`-pg_log_error("could not fsync file \"%s\": %m",outfile);`
`196`		`-return false;`
	`195`	`+pg_log_fatal("could not fsync file \"%s\": %m",outfile);`
	`196`	`+exit(1);`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`return true;`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -134,10 +134,10 @@ open_walfile(StreamCtl *stream, XLogRecPtr startpoint)`
`134`	`134`	`/* fsync file in case of a previous crash */`
`135`	`135`	`if (stream->walmethod->sync(f)!=0)`
`136`	`136`	`{`
`137`		`-pg_log_error("could not fsync existing write-ahead log file \"%s\": %s",`
	`137`	`+pg_log_fatal("could not fsync existing write-ahead log file \"%s\": %s",`
`138`	`138`	`fn,stream->walmethod->getlasterror());`
`139`	`139`	`stream->walmethod->close(f,CLOSE_UNLINK);`
`140`		`-return false;`
	`140`	`+exit(1);`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`walfile=f;`
`@@ -763,9 +763,9 @@ HandleCopyStream(PGconn conn, StreamCtl stream,`
`763`	`763`	`{`
`764`	`764`	`if (stream->walmethod->sync(walfile)!=0)`
`765`	`765`	`{`
`766`		`-pg_log_error("could not fsync file \"%s\": %s",`
	`766`	`+pg_log_fatal("could not fsync file \"%s\": %s",`
`767`	`767`	`current_walfile_name,stream->walmethod->getlasterror());`
`768`		`-gotoerror;`
	`768`	`+exit(1);`
`769`	`769`	`}`
`770`	`770`	`lastFlushPosition=blockpos;`
`771`	`771`
`@@ -1015,9 +1015,9 @@ ProcessKeepaliveMsg(PGconn conn, StreamCtl stream, char *copybuf, int len,`
`1015`	`1015`	`*/`
`1016`	`1016`	`if (stream->walmethod->sync(walfile)!=0)`
`1017`	`1017`	`{`
`1018`		`-pg_log_error("could not fsync file \"%s\": %s",`
	`1018`	`+pg_log_fatal("could not fsync file \"%s\": %s",`
`1019`	`1019`	`current_walfile_name,stream->walmethod->getlasterror());`
`1020`		`-return false;`
	`1020`	`+exit(1);`
`1021`	`1021`	`}`
`1022`	`1022`	`lastFlushPosition=blockpos;`
`1023`	`1023`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -864,7 +864,7 @@ tar_close(Walfile f, WalCloseMethod method)`
`864`	`864`
`865`	`865`	`/* Always fsync on close, so the padding gets fsynced */`
`866`	`866`	`if (tar_sync(f)<0)`
`867`		`-return-1;`
	`867`	`+exit(1);`
`868`	`868`
`869`	`869`	`/* Clean up and done */`
`870`	`870`	`pg_free(tf->pathname);`

Comments

(0)