Commit1dad866

committed

Someone report me small bug in contrib/pg_dumplo today. It's problem

with a little dirty snprintf() usage which I used some years ago: snprintf(path, BUFSIZ, "%s/lo_dump.index", path);Karel Zak

1 parent6687152 commit1dad866Copy full SHA for 1dad866

File tree

-4

lines changed

-4

lines changed

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -------------------------------------------------------------------------`
`2`	`2`	`* pg_dumplo`
`3`	`3`	`*`
`4`		`- * $Header: /cvsroot/pgsql/contrib/pg_dumplo/Attic/utils.c,v 1.6 2002/09/05 21:01:16 tgl Exp $`
	`4`	`+ * $Header: /cvsroot/pgsql/contrib/pg_dumplo/Attic/utils.c,v 1.7 2003/10/09 13:38:05 momjian Exp $`
`5`	`5`	`*`
`6`	`6`	`*Karel Zak 1999-2000`
`7`	`7`	`* -------------------------------------------------------------------------`
`@@ -30,6 +30,7 @@ void`
`30`	`30`	`index_file(LODumpMaster*pgLO)`
`31`	`31`	`{`
`32`	`32`	`charpath[BUFSIZ];`
	`33`	`+intsz;`
`33`	`34`
`34`	`35`	`if (pgLO->action==ACTION_SHOW)`
`35`	`36`	`return;`
`@@ -49,7 +50,8 @@ index_file(LODumpMaster * pgLO)`
`49`	`50`	`}`
`50`	`51`	`}`
`51`	`52`
`52`		`-snprintf(path,BUFSIZ,"%s/lo_dump.index",path);`
	`53`	`+sz=strlen(path);`
	`54`	`+strncat(path,"/lo_dump.index",BUFSIZ-sz);`
`53`	`55`
`54`	`56`	`if ((pgLO->index=fopen(path,"w"))==NULL)`
`55`	`57`	`{`
`@@ -60,8 +62,8 @@ index_file(LODumpMaster * pgLO)`
`60`	`62`	`}`
`61`	`63`	`elseif (pgLO->action!=ACTION_NONE)`
`62`	`64`	`{`
`63`		`-`
`64`		`-snprintf(path,BUFSIZ,"%s/lo_dump.index",path);`
	`65`	`+sz=strlen(path);`
	`66`	`+strncat(path,"/lo_dump.index",BUFSIZ-sz);`
`65`	`67`
`66`	`68`	`if ((pgLO->index=fopen(path,"r"))==NULL)`
`67`	`69`	`{`

Comments

(0)