NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1d80d6b

committed

Further reduce dependence on -fwrapv semantics in jsonb.

Commit108d2ad missed updating a few places in the jsonb codethat rely on signed integer wrapping for correctness. These canalso be fixed by using pg_abs_s32() to negate a signed integer(that is known to be negative) for comparison with an unsignedinteger.Reported-by: Alexander LakhinDiscussion:https://postgr.es/m/bfff906f-300d-81ea-83b7-f2c93845e7f2%40gmail.com

1 parentaa2d6b1 commit1d80d6bCopy full SHA for 1d80d6b

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- jsonfuncs.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/jsonfuncs.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -990,7 +990,7 @@ jsonb_array_element_text(PG_FUNCTION_ARGS)`
`990`	`990`	`{`
`991`	`991`	`uint32nelements=JB_ROOT_COUNT(jb);`
`992`	`992`
`993`		`-if (-element>nelements)`
	`993`	`+if (pg_abs_s32(element)>nelements)`
`994`	`994`	`PG_RETURN_NULL();`
`995`	`995`	`else`
`996`	`996`	`element+=nelements;`
`@@ -4811,7 +4811,7 @@ jsonb_delete_idx(PG_FUNCTION_ARGS)`
`4811`	`4811`
`4812`	`4812`	`if (idx<0)`
`4813`	`4813`	`{`
`4814`		`-if (-idx>n)`
	`4814`	`+if (pg_abs_s32(idx)>n)`
`4815`	`4815`	`idx=n;`
`4816`	`4816`	`else`
`4817`	`4817`	`idx=n+idx;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1d80d6b

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/jsonfuncs.c`

0 commit comments