NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1d581ce

committed

Fix misuse of foreach_delete_current().

Our coding convention requires this macro's result to be assignedback to the original List variable. In this usage, since theList could not become empty, there was no actual bug --- butsome compilers warned about it. Oversight inbe45be9.Discussion:https://postgr.es/m/35077b31-2d62-1e31-0e2e-ddb52d590b73@enterprisedb.com

1 parentbe45be9 commit1d581ceCopy full SHA for 1d581ce

File tree

1 file changed

-2

lines changed

src/backend/parser
- parse_agg.c

1 file changed

-2

lines changed

`‎src/backend/parser/parse_agg.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1844,11 +1844,11 @@ expand_grouping_sets(List *groupingSets, bool groupDistinct, int limit)`
`1844`	`1844`	`list_sort(result,cmp_list_len_contents_asc);`
`1845`	`1845`
`1846`	`1846`	`/* Finally, remove duplicates */`
`1847`		`-prev=list_nth_node(List,result,0);`
	`1847`	`+prev=linitial_node(List,result);`
`1848`	`1848`	`for_each_from(cell,result,1)`
`1849`	`1849`	`{`
`1850`	`1850`	`if (equal(lfirst(cell),prev))`
`1851`		`-foreach_delete_current(result,cell);`
	`1851`	`+result=foreach_delete_current(result,cell);`
`1852`	`1852`	`else`
`1853`	`1853`	`prev=lfirst(cell);`
`1854`	`1854`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1d581ce

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_agg.c`

0 commit comments