NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1d1b32a

committed

Address ccvalid/ccnoinherit in TupleDesc support functions.

equalTupleDescs() neglected both of these ConstrCheck fields, andCreateTupleDescCopyConstr() neglected ccnoinherit. At this time, theonly known behavior defect resulting from these omissions is constraintexclusion disregarding a CHECK constraint validated by an ALTER TABLEVALIDATE CONSTRAINT statement issued earlier in the same transaction.Back-patch to 9.2, where these fields were introduced.

1 parentee42d8f commit1d1b32aCopy full SHA for 1d1b32a

File tree

1 file changed

-1

lines changed

src/backend/access/common
- tupdesc.c

1 file changed

-1

lines changed

`‎src/backend/access/common/tupdesc.c‎`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -203,6 +203,7 @@ CreateTupleDescCopyConstr(TupleDesc tupdesc)`
`203`	`203`	`if (constr->check[i].ccbin)`
`204`	`204`	`cpy->check[i].ccbin=pstrdup(constr->check[i].ccbin);`
`205`	`205`	`cpy->check[i].ccvalid=constr->check[i].ccvalid;`
	`206`	`+cpy->check[i].ccnoinherit=constr->check[i].ccnoinherit;`
`206`	`207`	`}`
`207`	`208`	`}`
`208`	`209`
`@@ -416,7 +417,9 @@ equalTupleDescs(TupleDesc tupdesc1, TupleDesc tupdesc2)`
`416`	`417`	`for (j=0;j<n;check2++,j++)`
`417`	`418`	`{`
`418`	`419`	`if (strcmp(check1->ccname,check2->ccname)==0&&`
`419`		`-strcmp(check1->ccbin,check2->ccbin)==0)`
	`420`	`+strcmp(check1->ccbin,check2->ccbin)==0&&`
	`421`	`+check1->ccvalid==check2->ccvalid&&`
	`422`	`+check1->ccnoinherit==check2->ccnoinherit)`
`420`	`423`	`break;`
`421`	`424`	`}`
`422`	`425`	`if (j >=n)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1d1b32a

File tree

1 file changed

1 file changed

`‎src/backend/access/common/tupdesc.c‎`

0 commit comments