NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1d04a59

committed

Make walsender always initialize the buffers.

Walsender uses the local buffers for each outgoing and incoming message.Previously when creating replication slot, walsender forgot to initializeone of them and which can cause the segmentation fault error. To fix thisissue, this commit changes walsender so that it always initialize thembefore it executes the requested replication command.Back-patch to 9.4 where replication slot was introduced.Problem report and initial patch by Stas Kelvich, modified by me.Report:https://www.postgresql.org/message-id/A1E9CB90-1FAC-4CAD-8DBA-9AA62A6E97C5@postgrespro.ru

1 parentd365370 commit1d04a59Copy full SHA for 1d04a59

File tree

1 file changed

-10

lines changed

src/backend/replication
- walsender.c

1 file changed

-10

lines changed

`‎src/backend/replication/walsender.c`

Lines changed: 8 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -773,8 +773,6 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)`
`773`	`773`	`cmd->temporary ?RS_TEMPORARY :RS_EPHEMERAL);`
`774`	`774`	`}`
`775`	`775`
`776`		`-initStringInfo(&output_message);`
`777`		`-`
`778`	`776`	`if (cmd->kind==REPLICATION_KIND_LOGICAL)`
`779`	`777`	`{`
`780`	`778`	`LogicalDecodingContext*ctx;`
`@@ -1258,6 +1256,14 @@ exec_replication_command(const char *cmd_string)`
`1258`	`1256`
`1259`	`1257`	`cmd_node=replication_parse_result;`
`1260`	`1258`
	`1259`	`+/*`
	`1260`	`+ * Allocate buffers that will be used for each outgoing and incoming`
	`1261`	`+ * message. We do this just once per command to reduce palloc overhead.`
	`1262`	`+ */`
	`1263`	`+initStringInfo(&output_message);`
	`1264`	`+initStringInfo(&reply_message);`
	`1265`	`+initStringInfo(&tmpbuf);`
	`1266`	`+`
`1261`	`1267`	`switch (cmd_node->type)`
`1262`	`1268`	`{`
`1263`	`1269`	`caseT_IdentifySystemCmd:`
`@@ -1736,14 +1742,6 @@ WalSndCheckTimeOut(TimestampTz now)`
`1736`	`1742`	`staticvoid`
`1737`	`1743`	`WalSndLoop(WalSndSendDataCallbacksend_data)`
`1738`	`1744`	`{`
`1739`		`-/*`
`1740`		`- * Allocate buffers that will be used for each outgoing and incoming`
`1741`		`- * message. We do this just once to reduce palloc overhead.`
`1742`		`- */`
`1743`		`-initStringInfo(&output_message);`
`1744`		`-initStringInfo(&reply_message);`
`1745`		`-initStringInfo(&tmpbuf);`
`1746`		`-`
`1747`	`1745`	`/*`
`1748`	`1746`	`* Initialize the last reply timestamp. That enables timeout processing`
`1749`	`1747`	`* from hereon.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1d04a59

File tree

1 file changed

1 file changed

`‎src/backend/replication/walsender.c`

0 commit comments