NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1cfa69d

committed

LLVMJIT: Check for 'noinline' attribute in recursively inlined functions.

Previously the attribute was only checked for external functionsinlined, not "static" functions that had to be inlined asdependencies.This isn't really a bug, but makes debugging a bit harder. The newbehaviour also makes more sense. Therefore backpatch.Author: Andres FreundBackpatch: 11-, where JIT compilation was added

1 parentf2db5f3 commit1cfa69dCopy full SHA for 1cfa69d

File tree

1 file changed

-8

lines changed

src/backend/jit/llvm
- llvmjit_inline.cpp

1 file changed

-8

lines changed

`‎src/backend/jit/llvm/llvmjit_inline.cpp‎`

Lines changed: 7 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -287,14 +287,6 @@ llvm_build_inline_plan(llvm::Module *mod)`
`287`	`287`	`Assert(!funcDef->isDeclaration());`
`288`	`288`	`Assert(funcDef->hasExternalLinkage());`
`289`	`289`
`290`		`-/* don't inline functions marked as noinline*/`
`291`		`-if (funcDef->getAttributes().hasFnAttribute(llvm::Attribute::NoInline))`
`292`		`-{`
`293`		`-ilog(DEBUG1,"ineligibile to import %s due to noinline",`
`294`		`- symbolName.data());`
`295`		`-continue;`
`296`		`-}`
`297`		`-`
`298`	`290`	`llvm::StringSet<> importVars;`
`299`	`291`	`llvm::SmallPtrSet<const llvm::Function *,8> visitedFunctions;`
`300`	`292`	`int running_instcount =0;`
`@@ -600,6 +592,13 @@ function_inlinable(llvm::Function &F,`
`600`	`592`	`if (F.materialize())`
`601`	`593`	`elog(FATAL,"failed to materialize metadata");`
`602`	`594`
	`595`	`+if (F.getAttributes().hasFnAttribute(llvm::Attribute::NoInline))`
	`596`	`+{`
	`597`	`+ilog(DEBUG1,"ineligibile to import %s due to noinline",`
	`598`	`+ F.getName().data());`
	`599`	`+returnfalse;`
	`600`	`+}`
	`601`	`+`
`603`	`602`	`function_references(F, running_instcount, referencedVars, referencedFunctions);`
`604`	`603`
`605`	`604`	`for (llvm::GlobalVariable* rv: referencedVars)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1cfa69d

File tree

1 file changed

1 file changed

`‎src/backend/jit/llvm/llvmjit_inline.cpp‎`

0 commit comments