NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1c07350

committed

Improve error message for misuse of TZ, tz, OF formatting patterns.

Be specific about which pattern is being complained of, and avoid saying"it's not supported in to_date", which is just confusing if the error isactually coming out of to_timestamp. We can phrase it as "is onlysupported in to_char", instead. Also, use the term "formatting field" not"format pattern", because other error messages in the same file prefer thatterminology. (This isn't terribly consistent with the documentation, somaybe we should change all these error messages?)

1 parent10257fc commit1c07350Copy full SHA for 1c07350

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- formatting.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/formatting.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3031,7 +3031,9 @@ DCH_from_char(FormatNode node, char in, TmFromChar *out)`
`3031`	`3031`	`caseDCH_OF:`
`3032`	`3032`	`ereport(ERROR,`
`3033`	`3033`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`3034`		`-errmsg("\"TZ\"/\"tz\"/\"OF\" format patterns are not supported in to_date")));`
	`3034`	`+errmsg("formatting field \"%s\" is only supported in to_char",`
	`3035`	`+n->key->name)));`
	`3036`	`+break;`
`3035`	`3037`	`caseDCH_A_D:`
`3036`	`3038`	`caseDCH_B_C:`
`3037`	`3039`	`caseDCH_a_d:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1c07350

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/formatting.c`

0 commit comments