NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1c06590

committed

Install Windows crash dump handler before all else.

Apart from calling write_stderr() on failure, the handler depends on noPostgreSQL facilities. We have experienced crashes before reaching theformer call site. Given such an early crash, this change cannot hurtand may produce a helpful dump. Absent an early crash, this change hasno effect. Back-patch to 9.3 (all supported versions).Takayuki TsunakawaDiscussion:https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CD13@G01JPEXMBYT05

1 parent30e99ef commit1c06590Copy full SHA for 1c06590

File tree

1 file changed

-8

lines changed

src/backend/main
- main.c

1 file changed

-8

lines changed

`‎src/backend/main/main.c`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,14 @@ main(int argc, char *argv[])`
`69`	`69`	`{`
`70`	`70`	`booldo_check_root= true;`
`71`	`71`
	`72`	`+/*`
	`73`	`+ * If supported on the current platform, set up a handler to be called if`
	`74`	`+ * the backend/postmaster crashes with a fatal signal or exception.`
	`75`	`+ */`
	`76`	`+#if defined(WIN32)&& defined(HAVE_MINIDUMP_TYPE)`
	`77`	`+pgwin32_install_crashdump_handler();`
	`78`	`+#endif`
	`79`	`+`
`72`	`80`	`progname=get_progname(argv[0]);`
`73`	`81`
`74`	`82`	`/*`
`@@ -89,14 +97,6 @@ main(int argc, char *argv[])`
`89`	`97`	`*/`
`90`	`98`	`argv=save_ps_display_args(argc,argv);`
`91`	`99`
`92`		`-/*`
`93`		`- * If supported on the current platform, set up a handler to be called if`
`94`		`- * the backend/postmaster crashes with a fatal signal or exception.`
`95`		`- */`
`96`		`-#if defined(WIN32)&& defined(HAVE_MINIDUMP_TYPE)`
`97`		`-pgwin32_install_crashdump_handler();`
`98`		`-#endif`
`99`		`-`
`100`	`100`	`/*`
`101`	`101`	`* Fire up essential subsystems: error and memory management`
`102`	`102`	`*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1c06590

File tree

1 file changed

1 file changed

`‎src/backend/main/main.c`

0 commit comments