NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1bee3ca

committed

Stabilize just-added regression test cases.

The tests added by commits029dea8 et al turn out to producedifferent output under -DRANDOMIZE_ALLOCATED_MEMORY. This isnot a bug exactly: that flag causes coerce_type() to invokethe input function twice when coercing an unknown-type literalto a specific type. So you get tsqueryin's bleat about an emptytsquery twice. Revise the test query to avoid that.Discussion:https://postgr.es/m/20230406213813.uep7plg6lvcywujo@awork3.anarazel.de

1 parent34ad3ae commit1bee3caCopy full SHA for 1bee3ca

File tree

2 files changed

-8

lines changed

src/test/regress
- expected
  - tsearch.out
- sql
  - tsearch.sql

2 files changed

-8

lines changed

`‎src/test/regress/expected/tsearch.out`

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1992,20 +1992,16 @@ to_tsquery('english','Lorem') && phraseto_tsquery('english','ullamcorper urna'),`
`1992`	`1992`
`1993`	`1993`	`-- Edge cases with empty query`
`1994`	`1994`	`SELECT ts_headline('english',`
`1995`		`-'',''::tsquery);`
	`1995`	`+'',to_tsquery('english', ''));`
`1996`	`1996`	`NOTICE: text-search query doesn't contain lexemes: ""`
`1997`		`-LINE 2: '', ''::tsquery);`
`1998`		`- ^`
`1999`	`1997`	`ts_headline`
`2000`	`1998`	`-------------`
`2001`	`1999`
`2002`	`2000`	`(1 row)`
`2003`	`2001`
`2004`	`2002`	`SELECT ts_headline('english',`
`2005`		`-'foo bar',''::tsquery);`
	`2003`	`+'foo bar',to_tsquery('english', ''));`
`2006`	`2004`	`NOTICE: text-search query doesn't contain lexemes: ""`
`2007`		`-LINE 2: 'foo bar', ''::tsquery);`
`2008`		`- ^`
`2009`	`2005`	`ts_headline`
`2010`	`2006`	`-------------`
`2011`	`2007`	`foo bar`

`‎src/test/regress/sql/tsearch.sql`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -551,9 +551,9 @@ to_tsquery('english','Lorem') && phraseto_tsquery('english','ullamcorper urna'),`
`551`	`551`
`552`	`552`	`-- Edge cases with empty query`
`553`	`553`	`SELECT ts_headline('english',`
`554`		`-'',''::tsquery);`
	`554`	`+'',to_tsquery('english',''));`
`555`	`555`	`SELECT ts_headline('english',`
`556`		`-'foo bar',''::tsquery);`
	`556`	`+'foo bar',to_tsquery('english',''));`
`557`	`557`
`558`	`558`	`--Rewrite sub system`
`559`	`559`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1bee3ca

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/tsearch.out`

`‎src/test/regress/sql/tsearch.sql`

0 commit comments