Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1be4eb1

Browse files
committed
Disable abbreviated keys on Windows.
Most of the Windows buildfarm members (bowerbird, hamerkop, currawong,jacana, brolga) are unhappy with yesterday's abbreviated keys patch,although there are some (narwhal, frogmouth) that seem OK with it.Since there's no obvious pattern to explain why some are working andothers are failing, just disable this across-the-board on Windows fornow. This is a bit unfortunate since the optimization will be a bigwin in some cases, but we can't leave the buildfarm broken.
1 parentf259e71 commit1be4eb1

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

‎src/backend/utils/adt/varlena.c

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1744,14 +1744,22 @@ static void
17441744
btsortsupport_worker(SortSupportssup,Oidcollid)
17451745
{
17461746
TextSortSupport*tss;
1747+
boolabbreviate=ssup->abbreviate;
17471748

17481749
/*
17491750
* WIN32 requires complex hacks when the database encoding is UTF-8 (except
17501751
* when using the "C" collation). For now, we don't optimize that case.
1752+
* The use of abbreviated keys is also disabled on Windows, because
1753+
* strxfrm() doesn't appear to work properly on some Windows systems.
1754+
* Ideally, we would use it on those systems where it's reliable and
1755+
* skip it only for the rest, but at the moment we don't know how to
1756+
* distinguish between the ones where it works and the ones where it
1757+
* doesn't.
17511758
*/
17521759
#ifdefWIN32
17531760
if (GetDatabaseEncoding()==PG_UTF8&& !lc_collate_is_c(collid))
17541761
return;
1762+
abbreviate= false;
17551763
#endif
17561764

17571765
/*
@@ -1838,7 +1846,7 @@ btsortsupport_worker(SortSupport ssup, Oid collid)
18381846
else
18391847
ssup->abbrev_full_comparator=ssup->comparator=bttextfastcmp_locale;
18401848

1841-
if (!lc_collate_is_c(collid)||ssup->abbreviate)
1849+
if (!lc_collate_is_c(collid)||abbreviate)
18421850
{
18431851
/*
18441852
* Abbreviated case requires temp buffers for strxfrm() copying.
@@ -1852,7 +1860,7 @@ btsortsupport_worker(SortSupport ssup, Oid collid)
18521860
ssup->ssup_extra=tss;
18531861
}
18541862

1855-
if (!ssup->abbreviate)
1863+
if (!abbreviate)
18561864
return;
18571865

18581866
initHyperLogLog(&tss->abbr_card,10);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp