NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1bbf870

committed

It turns out the LIBXML_TEST_VERSION macro calls xmlInitParser().

Therefore we must xmlCleanupParser(), or we risk leaving behinddangling pointers to whatever memory context is current when xml_init()is called. This seems to fix bug #3860, though we might still wantthe more invasive solution being worked on by Alvaro.

1 parent5217663 commit1bbf870Copy full SHA for 1bbf870

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- xml.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/xml.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.66 2008/01/1210:50:03 neilc Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.67 2008/01/1221:14:08 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -958,6 +958,9 @@ xml_init(void)`
`958`	`958`	`/* Check library compatibility */`
`959`	`959`	`LIBXML_TEST_VERSION;`
`960`	`960`
	`961`	`+/* The above calls xmlInitParser(); must clean up dangling pointers */`
	`962`	`+xmlCleanupParser();`
	`963`	`+`
`961`	`964`	`first_time= false;`
`962`	`965`	`}`
`963`	`966`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1bbf870

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/xml.c`

0 commit comments