NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1bb6924

committed

Adjust total size in pg_basebackup progress report when reality changes

When streaming including WAL, the size estimate will always be incorrect,since we don't know how much WAL is included. To make sure the output doesn'tlook completely unreasonable, this patch increases the total size whenever wego past the estimate, to make sure we never go above 100%.

1 parent2877c67 commit1bb6924Copy full SHA for 1bb6924

File tree

1 file changed

-0

lines changed

src/bin/pg_basebackup
- pg_basebackup.c

1 file changed

-0

lines changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -207,8 +207,17 @@ progress_report(int tablespacenum, const char *filename)`
`207`	`207`	`chartotaldone_str[32];`
`208`	`208`	`chartotalsize_str[32];`
`209`	`209`
	`210`	`+/*`
	`211`	`+ * Avoid overflowing past 100% or the full size. This may make the`
	`212`	`+ * total size number change as we approach the end of the backup`
	`213`	`+ * (the estimate will always be wrong if WAL is included), but`
	`214`	`+ * that's better than having the done column be bigger than the`
	`215`	`+ * total.`
	`216`	`+ */`
`210`	`217`	`if (percent>100)`
`211`	`218`	`percent=100;`
	`219`	`+if (totaldone /1024>totalsize)`
	`220`	`+totalsize=totaldone /1024;`
`212`	`221`
`213`	`222`	`/*`
`214`	`223`	`* Separate step to keep platform-dependent format code out of translatable`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1bb6924

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

0 commit comments