NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1b63075

committed

Fix some more bugs in GIN's WAL replay logic.

In commit4016bde I fixed a bunch ofginxlog.c bugs having to do with not handling XLogReadBuffer failurescorrectly. However, in ginRedoUpdateMetapage and ginRedoDeleteListPages,I unaccountably thought that failure to read the metapage would beimpossible and just put in an elog(PANIC) call. This is of course wrong:failure is exactly what will happen if the index got dropped (or rebuilt)between creation of the WAL record and the crash we're trying to recoverfrom. I believe this explains Nicholas Wilson's recent report of theseerrors getting reached.Also, fix memory leak in forgetIncompleteSplit. This wasn't of muchconcern when the code was written, but in a long-running standby serverpage split records could be expected to accumulate indefinitely.Back-patch to 8.4 --- before that, GIN didn't have a metapage.

1 parentb5c077c commit1b63075Copy full SHA for 1b63075

File tree

1 file changed

-3

lines changed

src/backend/access/gin
- ginxlog.c

1 file changed

-3

lines changed

`‎src/backend/access/gin/ginxlog.c`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,12 @@ forgetIncompleteSplit(RelFileNode node, BlockNumber leftBlkno, BlockNumber updat`
`58`	`58`	`{`
`59`	`59`	`ginIncompleteSplitsplit= (ginIncompleteSplit)lfirst(l);`
`60`	`60`
`61`		`-if (RelFileNodeEquals(node,split->node)&&leftBlkno==split->leftBlkno&&updateBlkno==split->rightBlkno)`
	`61`	`+if (RelFileNodeEquals(node,split->node)&&`
	`62`	`+leftBlkno==split->leftBlkno&&`
	`63`	`+updateBlkno==split->rightBlkno)`
`62`	`64`	`{`
`63`	`65`	`incomplete_splits=list_delete_ptr(incomplete_splits,split);`
	`66`	`+pfree(split);`
`64`	`67`	`break;`
`65`	`68`	`}`
`66`	`69`	`}`
`@@ -486,7 +489,7 @@ ginRedoUpdateMetapage(XLogRecPtr lsn, XLogRecord *record)`
`486`	`489`
`487`	`490`	`metabuffer=XLogReadBuffer(data->node,GIN_METAPAGE_BLKNO, false);`
`488`	`491`	`if (!BufferIsValid(metabuffer))`
`489`		`-elog(PANIC,"GIN metapage disappeared");`
	`492`	`+return;/* assume index was deleted, nothing to do */`
`490`	`493`	`metapage=BufferGetPage(metabuffer);`
`491`	`494`
`492`	`495`	`if (!XLByteLE(lsn,PageGetLSN(metapage)))`
`@@ -631,7 +634,7 @@ ginRedoDeleteListPages(XLogRecPtr lsn, XLogRecord *record)`
`631`	`634`
`632`	`635`	`metabuffer=XLogReadBuffer(data->node,GIN_METAPAGE_BLKNO, false);`
`633`	`636`	`if (!BufferIsValid(metabuffer))`
`634`		`-elog(PANIC,"GIN metapage disappeared");`
	`637`	`+return;/* assume index was deleted, nothing to do */`
`635`	`638`	`metapage=BufferGetPage(metabuffer);`
`636`	`639`
`637`	`640`	`if (!XLByteLE(lsn,PageGetLSN(metapage)))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1b63075

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginxlog.c`

0 commit comments