Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1b5841d

Browse files
committed
Remove unnecessary (char *) casts [checksum]
Remove some (char *) casts related to uses of the pg_checksum_page()function. These casts are useless, because everything involvedalready has the right type. Moreover, these casts actually silentlydiscarded a const qualifier. The declaration of a higher-levelfunction needs to be adjusted to fix that.Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>Discussion:https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org
1 parent827b406 commit1b5841d

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

‎contrib/pageinspect/rawpage.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ page_checksum_internal(PG_FUNCTION_ARGS, enum pageinspect_version ext_version)
357357
if (PageIsNew(page))
358358
PG_RETURN_NULL();
359359

360-
PG_RETURN_INT16(pg_checksum_page((char*)page,blkno));
360+
PG_RETURN_INT16(pg_checksum_page(page,blkno));
361361
}
362362

363363
Datum

‎src/backend/storage/page/bufpage.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ PageInit(Page page, Size pageSize, Size specialSize)
8585
* to pgstat.
8686
*/
8787
bool
88-
PageIsVerifiedExtended(constPageData*page,BlockNumberblkno,intflags)
88+
PageIsVerifiedExtended(PageData*page,BlockNumberblkno,intflags)
8989
{
9090
constPageHeaderData*p= (constPageHeaderData*)page;
9191
size_t*pagebytes;
@@ -100,7 +100,7 @@ PageIsVerifiedExtended(const PageData *page, BlockNumber blkno, int flags)
100100
{
101101
if (DataChecksumsEnabled())
102102
{
103-
checksum=pg_checksum_page((char*)page,blkno);
103+
checksum=pg_checksum_page(page,blkno);
104104

105105
if (checksum!=p->pd_checksum)
106106
checksum_failure= true;
@@ -1534,5 +1534,5 @@ PageSetChecksumInplace(Page page, BlockNumber blkno)
15341534
if (PageIsNew(page)|| !DataChecksumsEnabled())
15351535
return;
15361536

1537-
((PageHeader)page)->pd_checksum=pg_checksum_page((char*)page,blkno);
1537+
((PageHeader)page)->pd_checksum=pg_checksum_page(page,blkno);
15381538
}

‎src/include/storage/bufpage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ StaticAssertDecl(BLCKSZ == ((BLCKSZ / sizeof(size_t)) * sizeof(size_t)),
489489
"BLCKSZ has to be a multiple of sizeof(size_t)");
490490

491491
externvoidPageInit(Pagepage,SizepageSize,SizespecialSize);
492-
externboolPageIsVerifiedExtended(constPageData*page,BlockNumberblkno,intflags);
492+
externboolPageIsVerifiedExtended(PageData*page,BlockNumberblkno,intflags);
493493
externOffsetNumberPageAddItemExtended(Pagepage,Itemitem,Sizesize,
494494
OffsetNumberoffsetNumber,intflags);
495495
externPagePageGetTempPage(constPageData*page);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp