NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1b26bd4

committed

Fix bug with view locking code.

LockViewRecurese() obtains view relation using heap_open() and passesit to get_view_query() to get view info. It immediately closes therelation then uses the returned view info by callingLockViewRecurse_walker(). Since get_view_query() returns a pointerwithin the relcache, the relcache should be kept untilLockViewRecurse_walker() returns. Otherwise the relation could pointto a garbage memory area.Fix is moving the heap_close() call after LockViewRecurse_walker().Problem reported by Tom Lane (buildfarm is unhappy, especially prionsince it enables -DRELCACHE_FORCE_RELEASE cpp flag), fix by me.

1 parent3e256e5 commit1b26bd4Copy full SHA for 1b26bd4

File tree

1 file changed

-1

lines changed

src/backend/commands
- lockcmds.c

1 file changed

-1

lines changed

`‎src/backend/commands/lockcmds.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,6 @@ LockViewRecurse(Oid reloid, Oid root_reloid, LOCKMODE lockmode, bool nowait)`
`263`	`263`
`264`	`264`	`view=heap_open(reloid,NoLock);`
`265`	`265`	`viewquery=get_view_query(view);`
`266`		`-heap_close(view,NoLock);`
`267`	`266`
`268`	`267`	`context.root_reloid=root_reloid;`
`269`	`268`	`context.lockmode=lockmode;`
`@@ -272,6 +271,8 @@ LockViewRecurse(Oid reloid, Oid root_reloid, LOCKMODE lockmode, bool nowait)`
`272`	`271`	`context.viewoid=reloid;`
`273`	`272`
`274`	`273`	`LockViewRecurse_walker((Node*)viewquery,&context);`
	`274`	`+`
	`275`	`+heap_close(view,NoLock);`
`275`	`276`	`}`
`276`	`277`
`277`	`278`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1b26bd4

File tree

1 file changed

1 file changed

`‎src/backend/commands/lockcmds.c`

0 commit comments