Commit1aadc50

committed

Remove obsolete comment and code from fe-auth.c.

We don't use getpwuid() anymore (see commite757cdd), so we don't needlocking around pg_get_user_name().Reviewed-by: Andres Freund <andres@anarazel.de>Reviewed-by: Peter Eisentraut <peter@eisentraut.org>Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>Discussion:https://postgr.es/m/CA%2BhUKGLtmexrpMtxBRLCVePqV_dtWG-ZsEbyPrYc%2BNBB2TkNsw%40mail.gmail.com

1 parent8d9a9f0 commit1aadc50Copy full SHA for 1aadc50

File tree

-11

lines changed

-11

lines changed

Lines changed: 0 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -1179,15 +1179,6 @@ pg_fe_getusername(uid_t user_id, PQExpBuffer errorMessage)`
`1179`	`1179`	`charpwdbuf[BUFSIZ];`
`1180`	`1180`	`#endif`
`1181`	`1181`
`1182`		`-/*`
`1183`		`- * Some users are using configure --enable-thread-safety-force, so we`
`1184`		`- * might as well do the locking within our library to protect getpwuid().`
`1185`		`- * In fact, application developers can use getpwuid() in their application`
`1186`		`- * if they use the locking call we provide, or install their own locking`
`1187`		`- * function using PQregisterThreadLock().`
`1188`		`- */`
`1189`		`-pglock_thread();`
`1190`		`-`
`1191`	`1182`	`#ifdefWIN32`
`1192`	`1183`	`if (GetUserName(username,&namesize))`
`1193`	`1184`	`name=username;`
`@@ -1209,8 +1200,6 @@ pg_fe_getusername(uid_t user_id, PQExpBuffer errorMessage)`
`1209`	`1200`	`libpq_append_error(errorMessage,"out of memory");`
`1210`	`1201`	`}`
`1211`	`1202`
`1212`		`-pgunlock_thread();`
`1213`		`-`
`1214`	`1203`	`returnresult;`
`1215`	`1204`	`}`
`1216`	`1205`

Comments

(0)