NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1a72124

committed

Don't assume expr is available in pgbench tests

Windows hosts do not normally come with expr, so instead of using thatto test the \setshell command, use echo instead, which is fairlyuniversally available.Backpatch to release 11, where this came in.Problem found by me, patch by Fabien Coelho.

1 parentfd7d387 commit1a72124Copy full SHA for 1a72124

File tree

1 file changed

-5

lines changed

src/bin/pgbench/t
- 001_pgbench_with_server.pl

1 file changed

-5

lines changed

`‎src/bin/pgbench/t/001_pgbench_with_server.pl`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -512,7 +512,7 @@ sub pgbench`
`512`	`512`	`qr{processed: 1/1},`
`513`	`513`	`qr{shell-echo-output}`
`514`	`514`	`],`
`515`		`-[qr{command=8.: int2\b}],`
	`515`	`+[qr{command=8.: int1\b}],`
`516`	`516`	`'pgbench backslash commands',`
`517`	`517`	`{`
`518`	`518`	`'001_pgbench_backslash_commands'=>q{-- run set`
`@@ -524,10 +524,10 @@ sub pgbench`
`524`	`524`	`\sleep 0 s`
`525`	`525`	`\sleep :zero`
`526`	`526`	`-- setshell and continuation`
`527`		`-\setshelltwo\`
`528`		`-expr \`
`529`		`-1 +:one`
`530`		`-\set n debug(:two)`
	`527`	`+\setshellanother_one\`
	`528`	`+echo \`
	`529`	`+ :one`
	`530`	`+\set n debug(:another_one)`
`531`	`531`	`-- shell`
`532`	`532`	`\shell echo shell-echo-output`
`533`	`533`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1a72124

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/t/001_pgbench_with_server.pl`

0 commit comments