Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1a40485

Browse files
committed
Fix pgxs.mk to not try to build generated headers in external builds.
Per Julien Rouhaud and the buildfarm. This is not quite Julien'spatch: there's no need to lobotomize this build rule when buildingcontrib modules in-tree, so set NO_GENERATED_HEADERS only if PGXS.In passing, also set NO_TEMP_INSTALL in external builds. This doesn'tseem to be fixing any live bug, because "make check" in an externalbuild just produces the expected error message without first trying tomake a temp install ... but it's far from obvious why it doesn't, sothis change seems like good future-proofing.Julien Rouhaud and Tom LaneDiscussion:https://postgr.es/m/CAOBaU_YH=g68opbbMk8is3jNwhoXGa8ckRSre1nx0Obe1C7i-Q@mail.gmail.com
1 parent29d7ebf commit1a40485

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

‎src/makefiles/pgxs.mk

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,12 @@ endif
6262

6363

6464
ifdefPGXS
65+
66+
# External extensions must assume generated headers are available
67+
NO_GENERATED_HEADERS=yes
68+
# The temp-install rule won't work, either
69+
NO_TEMP_INSTALL=yes
70+
6571
# We assume that we are in src/makefiles/, so top is ...
6672
top_builddir :=$(dir$(PGXS))../..
6773
include$(top_builddir)/src/Makefile.global
@@ -75,7 +81,8 @@ endif
7581
ifeq ($(FLEX),)
7682
FLEX = flex
7783
endif
78-
endif
84+
85+
endif# PGXS
7986

8087

8188
overrideCPPFLAGS := -I. -I$(srcdir)$(CPPFLAGS)

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp