Commit1a3efa1

committed

Fix EXTRACT(ISOYEAR FROM timestamp) for years BC.

The test cases added by commit26ae3aa exposed an old oversight intimestamp[tz]_part: they didn't correct the result of date2isoyear()for BC years, so that we produced an off-by-one answer for such years.Fix that, and back-patch to all supported branches.Discussion:https://postgr.es/m/SG2PR06MB37762CAE45DB0F6CA7001EA9B6550@SG2PR06MB3776.apcprd06.prod.outlook.com

1 parent26ae3aa commit1a3efa1Copy full SHA for 1a3efa1

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4373,6 +4373,7 @@ date2isoweek(int year, int mon, int mday)`
`4373`	`4373`	`/* date2isoyear()`
`4374`	`4374`	`*`
`4375`	`4375`	`*Returns ISO 8601 year number.`
	`4376`	`+ *Note: zero or negative results follow the year-zero-exists convention.`
`4376`	`4377`	`*/`
`4377`	`4378`	`int`
`4378`	`4379`	`date2isoyear(intyear,intmon,intmday)`
`@@ -4647,6 +4648,9 @@ timestamp_part(PG_FUNCTION_ARGS)`
`4647`	`4648`
`4648`	`4649`	`caseDTK_ISOYEAR:`
`4649`	`4650`	`result=date2isoyear(tm->tm_year,tm->tm_mon,tm->tm_mday);`
	`4651`	`+/* Adjust BC years */`
	`4652`	`+if (result <=0)`
	`4653`	`+result-=1;`
`4650`	`4654`	`break;`
`4651`	`4655`
`4652`	`4656`	`caseDTK_DOW:`
`@@ -4843,6 +4847,9 @@ timestamptz_part(PG_FUNCTION_ARGS)`
`4843`	`4847`
`4844`	`4848`	`caseDTK_ISOYEAR:`
`4845`	`4849`	`result=date2isoyear(tm->tm_year,tm->tm_mon,tm->tm_mday);`
	`4850`	`+/* Adjust BC years */`
	`4851`	`+if (result <=0)`
	`4852`	`+result-=1;`
`4846`	`4853`	`break;`
`4847`	`4854`
`4848`	`4855`	`caseDTK_DOW:`

Lines changed: 1 addition & 1 deletion

Lines changed: 1 addition & 1 deletion

Comments

(0)