NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit19cd31b

committed

Fix bug introduced into _bt_getstackbuf() on 2003-Feb-21: the initial

value of 'start' could be past the end of the page, if the page wassplit by some concurrent inserting process since we visited it. Inthis situation the code could look at bogus entries and possibly finda match (since after all those entries still contain what they hadbefore the split). This would lead to 'specified item offset is too large'followed by 'PANIC: failed to add item to the page', as reported by JoeConway for scenarios involving heavy concurrent insertion activity.

1 parentfcaad7e commit19cd31bCopy full SHA for 19cd31b

File tree

1 file changed

-1

lines changed

src/backend/access/nbtree
- nbtinsert.c

1 file changed

-1

lines changed

`‎src/backend/access/nbtree/nbtinsert.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.113 2004/07/21 22:31:19 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.114 2004/08/17 23:15:33 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1311,6 +1311,13 @@ _bt_getstackbuf(Relation rel, BTStack stack, int access)`
`1311`	`1311`	`if (start<minoff)`
`1312`	`1312`	`start=minoff;`
`1313`	`1313`
	`1314`	`+/*`
	`1315`	`+ * Need this check too, to guard against possibility that page`
	`1316`	`+ * split since we visited it originally.`
	`1317`	`+ */`
	`1318`	`+if (start>maxoff)`
	`1319`	`+start=OffsetNumberNext(maxoff);`
	`1320`	`+`
`1314`	`1321`	`/*`
`1315`	`1322`	`* These loops will check every item on the page --- but in an`
`1316`	`1323`	`* order that's attuned to the probability of where it`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit19cd31b

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtinsert.c`

0 commit comments