Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1908511

Browse files
committed
Cooperate with the Valgrind instrumentation framework.
Valgrind "client requests" in aset.c and mcxt.c teach Valgrind and itsMemcheck tool about the PostgreSQL allocator. This makes Valgrindroughly as sensitive to memory errors involving palloc chunks as it isto memory errors involving malloc chunks. Further client requests inPageAddItem() and printtup() verify that all bits being added to abuffer page or furnished to an output function are predictably-defined.Those tests catch failures of C-language functions to fully initializethe bits of a Datum, which in turn stymie optimizations that rely on_equalConst(). Define the USE_VALGRIND symbol in pg_config_manual.h toenable these additions. An included "suppression file" silences nominalerrors we don't plan to fix.Reviewed in earlier versions by Peter Geoghegan and Korry Douglas.
1 parenta855148 commit1908511

File tree

8 files changed

+361
-7
lines changed

8 files changed

+361
-7
lines changed

‎src/backend/access/common/printtup.c

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
#include"libpq/pqformat.h"
2121
#include"tcop/pquery.h"
2222
#include"utils/lsyscache.h"
23+
#include"utils/memdebug.h"
2324

2425

2526
staticvoidprinttup_startup(DestReceiver*self,intoperation,
@@ -324,9 +325,26 @@ printtup(TupleTableSlot *slot, DestReceiver *self)
324325
/*
325326
* If we have a toasted datum, forcibly detoast it here to avoid
326327
* memory leakage inside the type's output routine.
328+
*
329+
* Here we catch undefined bytes in tuples that are returned to the
330+
* client without hitting disk; see comments at the related check in
331+
* PageAddItem(). Whether to test before or after detoast is somewhat
332+
* arbitrary, as is whether to test external/compressed data at all.
333+
* Undefined bytes in the pre-toast datum will have triggered Valgrind
334+
* errors in the compressor or toaster; any error detected here for
335+
* such datums would indicate an (unlikely) bug in a type-independent
336+
* facility. Therefore, this test is most useful for uncompressed,
337+
* non-external datums.
338+
*
339+
* We don't presently bother checking non-varlena datums for undefined
340+
* data. PageAddItem() does check them.
327341
*/
328342
if (thisState->typisvarlena)
343+
{
344+
VALGRIND_CHECK_MEM_IS_DEFINED(origattr,VARSIZE_ANY(origattr));
345+
329346
attr=PointerGetDatum(PG_DETOAST_DATUM(origattr));
347+
}
330348
else
331349
attr=origattr;
332350

‎src/backend/storage/page/bufpage.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include"access/htup_details.h"
1818
#include"access/xlog.h"
1919
#include"storage/checksum.h"
20+
#include"utils/memdebug.h"
2021
#include"utils/memutils.h"
2122

2223

@@ -297,6 +298,20 @@ PageAddItem(Page page,
297298
/* set the item pointer */
298299
ItemIdSetNormal(itemId,upper,size);
299300

301+
/*
302+
* Items normally contain no uninitialized bytes. Core bufpage consumers
303+
* conform, but this is not a necessary coding rule; a new index AM could
304+
* opt to depart from it. However, data type input functions and other
305+
* C-language functions that synthesize datums should initialize all
306+
* bytes; datumIsEqual() relies on this. Testing here, along with the
307+
* similar check in printtup(), helps to catch such mistakes.
308+
*
309+
* Values of the "name" type retrieved via index-only scans may contain
310+
* uninitialized bytes; see comment in btrescan(). Valgrind will report
311+
* this as an error, but it is safe to ignore.
312+
*/
313+
VALGRIND_CHECK_MEM_IS_DEFINED(item,size);
314+
300315
/* copy the item's data onto the page */
301316
memcpy((char*)page+upper,item,size);
302317

‎src/backend/tcop/postgres.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
#include"tcop/tcopprot.h"
7070
#include"tcop/utility.h"
7171
#include"utils/lsyscache.h"
72+
#include"utils/memdebug.h"
7273
#include"utils/memutils.h"
7374
#include"utils/ps_status.h"
7475
#include"utils/snapmgr.h"
@@ -846,6 +847,10 @@ exec_simple_query(const char *query_string)
846847

847848
TRACE_POSTGRESQL_QUERY_START(query_string);
848849

850+
#ifdefUSE_VALGRIND
851+
VALGRIND_PRINTF("statement: %s\n",query_string);
852+
#endif
853+
849854
/*
850855
* We use save_log_statement_stats so ShowUsage doesn't report incorrect
851856
* results because ResetUsage wasn't called.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp