Commit187e1c9

michaelpq

authored and

pull[bot]

committed

Simplify some conditions related to [LW]Lock in generate-wait_event_types.pl

The first check on the enum values was not necessary as the values setin wait_event_names.txt for the classes LWLock and Lock were able tosatisfy the check. The second check when generating the C and headerfiles is now based on a match of the class names, making it simpler tounderstand.Author: Masahiro Ikeda, Michael PaquierDiscussion:https://postgr.es/m/eaf82a85c0ef1b55dc3b651d3f7b867a@oss.nttdata.com

1 parentb66ed60 commit187e1c9Copy full SHA for 187e1c9

File tree

1 file changed

-8

lines changed

src/backend/utils/activity
- generate-wait_event_types.pl

1 file changed

-8

lines changed

`‎src/backend/utils/activity/generate-wait_event_types.pl‎`

Lines changed: 3 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -85,13 +85,8 @@`
`85`	`85`	`my$trimmedwaiteventname =$waiteventenumname;`
`86`	`86`	`$trimmedwaiteventname =~s/^WAIT_EVENT_//;`
`87`	`87`
`88`		`-# An exception is required for LWLock and Lock as these don't require`
`89`		`-# any C and header files generated.`
`90`	`88`	`die"wait event names must start with 'WAIT_EVENT_'"`
`91`		`-if ($trimmedwaiteventnameeq$waiteventenumname`
`92`		`-&&$waiteventenumname !~/^LWLock/`
`93`		`-&&$waiteventenumname !~/^Lock/);`
`94`		`-$continue =",\n";`
	`89`	`+if ($trimmedwaiteventnameeq$waiteventenumname);`
`95`	`90`	`push(@{$hashwe{$waitclassname} },@waiteventlist);`
`96`	`91`	`}`
`97`	`92`
`@@ -141,8 +136,8 @@`
`141`	`136`	`# Don't generate .c and .h files for LWLock and Lock, these are`
`142`	`137`	`# handled independently.`
`143`	`138`	`next`
`144`		`-if ($waitclass=~/^WaitEventLWLock$/`
`145`		`-\|\|$waitclass=~/^WaitEventLock$/);`
	`139`	`+if ($waitclasseq'WaitEventLWLock'`
	`140`	`+\|\|$waitclasseq'WaitEventLock');`
`146`	`141`
`147`	`142`	`my$last =$waitclass;`
`148`	`143`	`$last =~s/^WaitEvent//;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit187e1c9

File tree

1 file changed

1 file changed

`‎src/backend/utils/activity/generate-wait_event_types.pl‎`

0 commit comments