NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit18730f8

committed

Fix inappropriate error messages for Hot Standby misconfiguration errors.

Give the correct name of the GUC parameter being complained of.Also, emit a more suitable SQLSTATE (INVALID_PARAMETER_VALUE,not the default INTERNAL_ERROR).Gurjeet Singh, errcode adjustment by me

1 parent26f4fc0 commit18730f8Copy full SHA for 18730f8

File tree

1 file changed

-4

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-4

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5944,9 +5944,10 @@ GetXLogReceiptTime(TimestampTz rtime, bool fromStream)`
`5944`	`5944`	`*/`
`5945`	`5945`	`#defineRecoveryRequiresIntParameter(param_name,currValue,minValue) \`
`5946`	`5946`	`do { \`
`5947`		`-if (currValue < minValue) \`
	`5947`	`+if ((currValue) <(minValue)) \`
`5948`	`5948`	`ereport(ERROR, \`
`5949`		`-(errmsg("hot standby is not possible because " \`
	`5949`	`+(errcode(ERRCODE_INVALID_PARAMETER_VALUE), \`
	`5950`	`+ errmsg("hot standby is not possible because " \`
`5950`	`5951`	`"%s = %d is a lower setting than on the master server " \`
`5951`	`5952`	`"(its value was %d)", \`
`5952`	`5953`	`param_name, \`
`@@ -5987,10 +5988,10 @@ CheckRequiredParameterValues(void)`
`5987`	`5988`	`RecoveryRequiresIntParameter("max_connections",`
`5988`	`5989`	`MaxConnections,`
`5989`	`5990`	`ControlFile->MaxConnections);`
`5990`		`-RecoveryRequiresIntParameter("max_prepared_xacts",`
	`5991`	`+RecoveryRequiresIntParameter("max_prepared_transactions",`
`5991`	`5992`	`max_prepared_xacts,`
`5992`	`5993`	`ControlFile->max_prepared_xacts);`
`5993`		`-RecoveryRequiresIntParameter("max_locks_per_xact",`
	`5994`	`+RecoveryRequiresIntParameter("max_locks_per_transaction",`
`5994`	`5995`	`max_locks_per_xact,`
`5995`	`5996`	`ControlFile->max_locks_per_xact);`
`5996`	`5997`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit18730f8

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments