Commit183c869

committed

adjust_partition_colnos mustn't be called if not needed

Add an assert to make this very explicit, as well as a code comment.The former should silence Coverity complaining about this.Introduced by7103ebb.Reported-by: Ranier VilelaDiscussion:https://postgr.es/m/CAEudQAqTTAOzXiYybab+1DQOb3ZUuK99=p_KD+yrRFhcDbd0jg@mail.gmail.com

1 parent4533de3 commit183c869Copy full SHA for 183c869

File tree

-0

lines changed

-0

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1530,19 +1530,25 @@ ExecBuildSlotPartitionKeyDescription(Relation rel,`
`1530`	`1530`	`* adjust_partition_colnos`
`1531`	`1531`	`*Adjust the list of UPDATE target column numbers to account for`
`1532`	`1532`	`*attribute differences between the parent and the partition.`
	`1533`	`+ *`
	`1534`	`+ * Note: mustn't be called if no adjustment is required.`
`1533`	`1535`	`*/`
`1534`	`1536`	`staticList*`
`1535`	`1537`	`adjust_partition_colnos(Listcolnos,ResultRelInfoleaf_part_rri)`
`1536`	`1538`	`{`
`1537`	`1539`	`TupleConversionMap*map=ExecGetChildToRootMap(leaf_part_rri);`
`1538`	`1540`
	`1541`	`+Assert(map!=NULL);`
	`1542`	`+`
`1539`	`1543`	`returnadjust_partition_colnos_using_map(colnos,map->attrMap);`
`1540`	`1544`	`}`
`1541`	`1545`
`1542`	`1546`	`/*`
`1543`	`1547`	`* adjust_partition_colnos_using_map`
`1544`	`1548`	`*Like adjust_partition_colnos, but uses a caller-supplied map instead`
`1545`	`1549`	`*of assuming to map from the "root" result relation.`
	`1550`	`+ *`
	`1551`	`+ * Note: mustn't be called if no adjustment is required.`
`1546`	`1552`	`*/`
`1547`	`1553`	`staticList*`
`1548`	`1554`	`adjust_partition_colnos_using_map(Listcolnos,AttrMapattrMap)`

Comments

(0)