NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit180cf87

committed

Remove ineffective heapam CHECK_FOR_INTERRUPTS().

Remove a CHECK_FOR_INTERRUPTS() call that could never actually handle aninterrupt. We always have a heap page buffer lock at this point.Having a useless CHECK_FOR_INTERRUPTS() call is harmless but misleading.It is probably possible to work around the immediate problem by movingthe CHECK_FOR_INTERRUPTS() to before the heap page buffer lock isacquired. That isn't enough to make the function responsive tointerrupts, though. The index AM caller will still hold an exclusivebuffer lock of its own.

1 parent098fb00 commit180cf87Copy full SHA for 180cf87

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam.c‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7086,7 +7086,6 @@ heap_compute_xid_horizon_for_tuples(Relation rel,`
`7086`	`7086`	`{`
`7087`	`7087`	`hoffnum=ItemIdGetRedirect(hitemid);`
`7088`	`7088`	`hitemid=PageGetItemId(hpage,hoffnum);`
`7089`		`-CHECK_FOR_INTERRUPTS();`
`7090`	`7089`	`}`
`7091`	`7090`
`7092`	`7091`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit180cf87

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c‎`

0 commit comments