Commit17fb603

committed

Improve error messages around REPLICATION and BYPASSRLS properties.

Clarify wording as per suggestion from Wolfgang Walther.No back-patch; this doesn't seem worth thrashing translatablestrings in the back branches.Tom Lane and Stephen FrostDiscussion:https://postgr.es/m/a5548a9f-89ee-3167-129d-162b5985fcf8@technowledgy.de

1 parentd907bd0 commit17fb603Copy full SHA for 17fb603

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ CreateRole(ParseState pstate, CreateRoleStmt stmt)`
`305`	`305`	`if (!superuser())`
`306`	`306`	`ereport(ERROR,`
`307`	`307`	`(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),`
`308`		`-errmsg("must be superuser tochange bypassrlsattribute")));`
	`308`	`+errmsg("must be superuser tocreate bypassrlsusers")));`
`309`	`309`	`}`
`310`	`310`	`else`
`311`	`311`	`{`
`@@ -719,14 +719,14 @@ AlterRole(AlterRoleStmt *stmt)`
`719`	`719`	`if (!superuser())`
`720`	`720`	`ereport(ERROR,`
`721`	`721`	`(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),`
`722`		`-errmsg("must be superuser to altersuperusers")));`
	`722`	`+errmsg("must be superuser to altersuperuser roles or change superuser attribute")));`
`723`	`723`	`}`
`724`	`724`	`elseif (authform->rolreplication\|\|isreplication >=0)`
`725`	`725`	`{`
`726`	`726`	`if (!superuser())`
`727`	`727`	`ereport(ERROR,`
`728`	`728`	`(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),`
`729`		`-errmsg("must be superuser to alter replicationusers")));`
	`729`	`+errmsg("must be superuser to alter replicationroles or change replication attribute")));`
`730`	`730`	`}`
`731`	`731`	`elseif (bypassrls >=0)`
`732`	`732`	`{`

Comments

(0)