NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit17d6a8f

committed

Improve stability of recently-added regression test case.

Commitb5febc1 added a contrib/btree_gist test case that has beenobserved to fail in the buildfarm as a result of background auto-analyzeupdating stats and changing the selected plan. Forestall that byforcibly analyzing in foreground, instead. The new plan choice isjust as good for our purposes, since we really only care that anindex-only plan does not get selected.Back-patch to 9.5, like the previous patch.Discussion:https://postgr.es/m/14643.1539629304@sss.pgh.pa.us

1 parent3dfef0c commit17d6a8fCopy full SHA for 17d6a8f

File tree

2 files changed

+12

-16

lines changed

contrib/btree_gist
- expected
  - inet.out
- sql
  - inet.sql

2 files changed

+12

-16

lines changed

`‎contrib/btree_gist/expected/inet.out`

Lines changed: 11 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,18 +64,16 @@ SELECT count(*) FROM inettmp WHERE a > '89.225.196.191'::inet;`
`64`	`64`	`386`
`65`	`65`	`(1 row)`
`66`	`66`
`67`		`-VACUUM inettmp;`
	`67`	`+VACUUMANALYZEinettmp;`
`68`	`68`	`-- gist_inet_ops lacks a fetch function, so this should not be index-only scan`
`69`	`69`	`EXPLAIN (COSTS OFF)`
`70`	`70`	`SELECT count(*) FROM inettmp WHERE a = '89.225.196.191'::inet;`
`71`		`-QUERY PLAN`
`72`		`---------------------------------------------------------`
	`71`	`+ QUERY PLAN`
	`72`	`+--------------------------------------------------`
`73`	`73`	`Aggregate`
`74`		`- -> Bitmap Heap Scan on inettmp`
`75`		`- Recheck Cond: (a = '89.225.196.191'::inet)`
`76`		`- -> Bitmap Index Scan on inetidx`
`77`		`- Index Cond: (a = '89.225.196.191'::inet)`
`78`		`-(5 rows)`
	`74`	`+ -> Index Scan using inetidx on inettmp`
	`75`	`+ Index Cond: (a = '89.225.196.191'::inet)`
	`76`	`+(3 rows)`
`79`	`77`
`80`	`78`	`SELECT count(*) FROM inettmp WHERE a = '89.225.196.191'::inet;`
`81`	`79`	`count`
`@@ -88,14 +86,12 @@ CREATE INDEX ON inettmp USING gist (a gist_inet_ops, a inet_ops);`
`88`	`86`	`-- likewise here (checks for core planner bug)`
`89`	`87`	`EXPLAIN (COSTS OFF)`
`90`	`88`	`SELECT count(*) FROM inettmp WHERE a = '89.225.196.191'::inet;`
`91`		`-QUERY PLAN`
`92`		`---------------------------------------------------------`
	`89`	`+ QUERY PLAN`
	`90`	`+----------------------------------------------------`
`93`	`91`	`Aggregate`
`94`		`- -> Bitmap Heap Scan on inettmp`
`95`		`- Recheck Cond: (a = '89.225.196.191'::inet)`
`96`		`- -> Bitmap Index Scan on inettmp_a_a1_idx`
`97`		`- Index Cond: (a = '89.225.196.191'::inet)`
`98`		`-(5 rows)`
	`92`	`+ -> Index Scan using inettmp_a_a1_idx on inettmp`
	`93`	`+ Index Cond: (a = '89.225.196.191'::inet)`
	`94`	`+(3 rows)`
`99`	`95`
`100`	`96`	`SELECT count(*) FROM inettmp WHERE a = '89.225.196.191'::inet;`
`101`	`97`	`count`

`‎contrib/btree_gist/sql/inet.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ SELECT count(*) FROM inettmp WHERE a >= '89.225.196.191'::inet;`
`30`	`30`
`31`	`31`	`SELECTcount(*)FROM inettmpWHERE a>'89.225.196.191'::inet;`
`32`	`32`
`33`		`-VACUUM inettmp;`
	`33`	`+VACUUMANALYZEinettmp;`
`34`	`34`
`35`	`35`	`-- gist_inet_ops lacks a fetch function, so this should not be index-only scan`
`36`	`36`	`EXPLAIN (COSTS OFF)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit17d6a8f

File tree

2 files changed

2 files changed

`‎contrib/btree_gist/expected/inet.out`

`‎contrib/btree_gist/sql/inet.sql`

0 commit comments