Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit17b8887

Browse files
committed
Fix race in SSI interaction with bitmap heap scan.
When performing a bitmap heap scan, we don't want to miss concurrentwrites that occurred after we observed the heap's rs_nblocks, but beforewe took predicate locks on index pages. Therefore, we can't skipfetching any heap tuples that are referenced by the index, because weneed to test them all with CheckForSerializableConflictOut(). Theold optimization that would ignore any references to blocks >=rs_nblocks gets in the way of that requirement, because it means thatconcurrent writes in that window are ignored.Removing that optimization shouldn't affect correctness at any isolationlevel, because any new tuples shouldn't be visible to an MVCC snapshot.There also shouldn't be any error-causing references to heap blocks pastthe end, because we should have held at least an AccessShareLock on thetable before the index scan. It can't get smaller while our transactionis running. For now, though, we'll keep the optimization at lowerlevels to avoid making unnecessary changes in a bug fix.Back-patch to all supported releases. In release 11, the code is in adifferent place but not fundamentally different. Fixes one aspect ofbug #17949.Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com>Reviewed-by: Dmitry Dolgov <9erthalion6@gmail.com>Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>Discussion:https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org
1 parentfe88497 commit17b8887

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎src/backend/access/heap/heapam_handler.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2247,9 +2247,11 @@ heapam_scan_bitmap_next_block(TableScanDesc scan,
22472247
* Ignore any claimed entries past what we think is the end of the
22482248
* relation. It may have been extended after the start of our scan (we
22492249
* only hold an AccessShareLock, and it could be inserts from this
2250-
* backend).
2250+
* backend). We don't take this optimization in SERIALIZABLE isolation
2251+
* though, as we need to examine all invisible tuples reachable by the
2252+
* index.
22512253
*/
2252-
if (page >=hscan->rs_nblocks)
2254+
if (!IsolationIsSerializable()&&page >=hscan->rs_nblocks)
22532255
return false;
22542256

22552257
/*

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp