NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit17a3f1c

committed

Fix incorrect logic in plan dependency recording

Both50e17ad and29f45e2 mistakenly tried to record a plan dependencyon a function but mistakenly inverted the OidIsValid test. This meantthat we'd record a dependency only when the function's Oid wasInvalidOid. Clearly this was meant to *not* record the dependency inthat case.50e17ad made this mistake first, then in v1529f45e2 copied the samemistake.Reported-by: Tom LaneBackpatch-through: 14, where50e17ad first made this mistakeDiscussion:https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us

1 parenta26cc03 commit17a3f1cCopy full SHA for 17a3f1c

File tree

1 file changed

-2

lines changed

src/backend/optimizer/plan
- setrefs.c

1 file changed

-2

lines changed

`‎src/backend/optimizer/plan/setrefs.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1886,10 +1886,10 @@ fix_expr_common(PlannerInfo root, Node node)`
`1886`	`1886`	`set_sa_opfuncid(saop);`
`1887`	`1887`	`record_plan_function_dependency(root,saop->opfuncid);`
`1888`	`1888`
`1889`		`-if (!OidIsValid(saop->hashfuncid))`
	`1889`	`+if (OidIsValid(saop->hashfuncid))`
`1890`	`1890`	`record_plan_function_dependency(root,saop->hashfuncid);`
`1891`	`1891`
`1892`		`-if (!OidIsValid(saop->negfuncid))`
	`1892`	`+if (OidIsValid(saop->negfuncid))`
`1893`	`1893`	`record_plan_function_dependency(root,saop->negfuncid);`
`1894`	`1894`	`}`
`1895`	`1895`	`elseif (IsA(node,Const))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit17a3f1c

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/setrefs.c‎`

0 commit comments