NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit17935e1

committed

Fix array subscript warnings

Commita5cf808 accidentally passed signed chars to isalpha andisspace in the parser code which leads to undefined behavior. Fixby casting the parameters to unsigned chars.Author: Pavel Stehule <pavel.stehule@gmail.com>Reported-by: Tom Lane <tgl@sss.pgh.pa.us>Reported-by: Michael Paquier <michael@paquier.xyz>Discussion:https://postgr.es/m/388186.1701315586@sss.pgh.pa.usDiscussion:https://postgr.es/m/ZWgg5xim2CXQcfmh@paquier.xyz

1 parentb589f21 commit17935e1Copy full SHA for 17935e1

File tree

1 file changed

-7

lines changed

src/bin/pg_dump
- filter.c

1 file changed

-7

lines changed

`‎src/bin/pg_dump/filter.c`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -185,14 +185,14 @@ filter_get_keyword(const char *line, int size)`
`185`	`185`	`*size=0;`
`186`	`186`
`187`	`187`	`/* Skip initial whitespace */`
`188`		`-while (isspace(*ptr))`
	`188`	`+while (isspace((unsignedchar)*ptr))`
`189`	`189`	`ptr++;`
`190`	`190`
`191`		`-if (isalpha(*ptr))`
	`191`	`+if (isalpha((unsignedchar)*ptr))`
`192`	`192`	`{`
`193`	`193`	`result=ptr++;`
`194`	`194`
`195`		`-while (isalpha(ptr)\|\|ptr=='_')`
	`195`	`+while (isalpha((unsignedchar)ptr)\|\|ptr=='_')`
`196`	`196`	`ptr++;`
`197`	`197`
`198`	`198`	`*size=ptr-result;`
`@@ -301,7 +301,7 @@ read_pattern(FilterStateData fstate, const char str, PQExpBuffer pattern)`
`301`	`301`	`boolfound_space= false;`
`302`	`302`
`303`	`303`	`/* Skip initial whitespace */`
`304`		`-while (isspace(*str))`
	`304`	`+while (isspace((unsignedchar)*str))`
`305`	`305`	`str++;`
`306`	`306`
`307`	`307`	`if (*str=='\0')`
`@@ -312,7 +312,7 @@ read_pattern(FilterStateData fstate, const char str, PQExpBuffer pattern)`
`312`	`312`
`313`	`313`	`while (str&&str!='#')`
`314`	`314`	`{`
`315`		`-while (str&& !isspace(str)&& !strchr("#,.()\"",*str))`
	`315`	`+while (str&& !isspace((unsignedchar)str)&& !strchr("#,.()\"",*str))`
`316`	`316`	`{`
`317`	`317`	`/*`
`318`	`318`	`* Append space only when it is allowed, and when it was found in`
`@@ -351,7 +351,7 @@ read_pattern(FilterStateData fstate, const char str, PQExpBuffer pattern)`
`351`	`351`	`found_space= false;`
`352`	`352`
`353`	`353`	`/* skip ending whitespaces */`
`354`		`-while (isspace(*str))`
	`354`	`+while (isspace((unsignedchar)*str))`
`355`	`355`	`{`
`356`	`356`	`found_space= true;`
`357`	`357`	`str++;`
`@@ -400,7 +400,7 @@ filter_read_item(FilterStateData *fstate,`
`400`	`400`	`fstate->lineno++;`
`401`	`401`
`402`	`402`	`/* Skip initial white spaces */`
`403`		`-while (isspace(*str))`
	`403`	`+while (isspace((unsignedchar)*str))`
`404`	`404`	`str++;`
`405`	`405`
`406`	`406`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit17935e1

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/filter.c`

0 commit comments