NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit171633f

committed

neqjoinsel must now pass through collation to eqjoinsel.

Since commit044c99b, eqjoinsel passes the passed-in collationto any operators it invokes. However, neqjoinsel failed to passon whatever collation it got, so that if we invoked acollation-dependent operator via that code path, we'd get "could notdetermine which collation to use for string comparison" or the like.Per report from Justin Pryzby. Back-patch to v12, like the previouscommit.Discussion:https://postgr.es/m/20200721191606.GL5748@telsasoft.com

1 parent43ef3c4 commit171633fCopy full SHA for 171633f

File tree

1 file changed

-6

lines changed

src/backend/utils/adt
- selfuncs.c

1 file changed

-6

lines changed

`‎src/backend/utils/adt/selfuncs.c‎`

Lines changed: 9 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -2552,6 +2552,7 @@ neqjoinsel(PG_FUNCTION_ARGS)`
`2552`	`2552`	`Listargs= (List)PG_GETARG_POINTER(2);`
`2553`	`2553`	`JoinTypejointype= (JoinType)PG_GETARG_INT16(3);`
`2554`	`2554`	`SpecialJoinInfosjinfo= (SpecialJoinInfo)PG_GETARG_POINTER(4);`
	`2555`	`+Oidcollation=PG_GET_COLLATION();`
`2555`	`2556`	`float8result;`
`2556`	`2557`
`2557`	`2558`	`if (jointype==JOIN_SEMI\|\|jointype==JOIN_ANTI)`
`@@ -2598,12 +2599,14 @@ neqjoinsel(PG_FUNCTION_ARGS)`
`2598`	`2599`
`2599`	`2600`	`if (eqop)`
`2600`	`2601`	`{`
`2601`		`-result=DatumGetFloat8(DirectFunctionCall5(eqjoinsel,`
`2602`		`-PointerGetDatum(root),`
`2603`		`-ObjectIdGetDatum(eqop),`
`2604`		`-PointerGetDatum(args),`
`2605`		`-Int16GetDatum(jointype),`
`2606`		`-PointerGetDatum(sjinfo)));`
	`2602`	`+result=`
	`2603`	`+DatumGetFloat8(DirectFunctionCall5Coll(eqjoinsel,`
	`2604`	`+collation,`
	`2605`	`+PointerGetDatum(root),`
	`2606`	`+ObjectIdGetDatum(eqop),`
	`2607`	`+PointerGetDatum(args),`
	`2608`	`+Int16GetDatum(jointype),`
	`2609`	`+PointerGetDatum(sjinfo)));`
`2607`	`2610`	`}`
`2608`	`2611`	`else`
`2609`	`2612`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit171633f

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/selfuncs.c‎`

0 commit comments