NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit16dcd5e

committed

GIN index build's allocatedMemory counter needs to be long, not uint32.

Else, in a 64-bit machine with maintenance_work_mem set to above 4Gb,the counter overflows and we never recognize having reached themaintenance_work_mem limit. I believe this explains out-of-memoryfailure recently reported by Sean Davis.This is a bug, so backpatch to 8.2.

1 parent0157945 commit16dcd5eCopy full SHA for 16dcd5e

File tree

1 file changed

-2

lines changed

src/include/access
- gin.h

1 file changed

-2

lines changed

`‎src/include/access/gin.h`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`*`
`5`	`5`	`*Copyright (c) 2006-2007, PostgreSQL Global Development Group`
`6`	`6`	`*`
`7`		`- *$PostgreSQL: pgsql/src/include/access/gin.h,v 1.14 2007/11/15 21:14:42 momjian Exp $`
	`7`	`+ *$PostgreSQL: pgsql/src/include/access/gin.h,v 1.15 2007/11/16 21:50:06 tgl Exp $`
`8`	`8`	`*--------------------------------------------------------------------------`
`9`	`9`	`*/`
`10`	`10`
`@@ -453,7 +453,7 @@ typedef struct`
`453`	`453`	`uint32maxdepth;`
`454`	`454`	`EntryAccumulator**stack;`
`455`	`455`	`uint32stackpos;`
`456`		`-uint32allocatedMemory;`
	`456`	`+longallocatedMemory;`
`457`	`457`
`458`	`458`	`uint32length;`
`459`	`459`	`EntryAccumulator*entryallocator;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit16dcd5e

File tree

1 file changed

1 file changed

`‎src/include/access/gin.h`

0 commit comments