NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit16a5677

committed

Fix variable lifespan in ExecInitCoerceToDomain().

This undoes a mistake in1ec7679: domainval and domainnull weremeant to live across loop iterations, but they were incorrectlymoved inside the loop. The effect was only to emit useless extraEEOP_MAKE_READONLY steps, so it's not a big deal; nonetheless,back-patch to v13 where the mistake was introduced.Ranier VilelaDiscussion:https://postgr.es/m/CAEudQAqXuhbkaAp-sGH6dR6Nsq7v28_0TPexHOm6FiDYqwQD-w@mail.gmail.com

1 parent08cfa59 commit16a5677Copy full SHA for 16a5677

File tree

1 file changed

-2

lines changed

src/backend/executor
- execExpr.c

1 file changed

-2

lines changed

`‎src/backend/executor/execExpr.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3121,6 +3121,8 @@ ExecInitCoerceToDomain(ExprEvalStep scratch, CoerceToDomain ctest,`
`3121`	`3121`	`ExprStatestate,Datumresv,bool*resnull)`
`3122`	`3122`	`{`
`3123`	`3123`	`DomainConstraintRef*constraint_ref;`
	`3124`	`+Datum*domainval=NULL;`
	`3125`	`+bool*domainnull=NULL;`
`3124`	`3126`	`ListCell*l;`
`3125`	`3127`
`3126`	`3128`	`scratch->d.domaincheck.resulttype=ctest->resulttype;`
`@@ -3167,8 +3169,6 @@ ExecInitCoerceToDomain(ExprEvalStep scratch, CoerceToDomain ctest,`
`3167`	`3169`	`foreach(l,constraint_ref->constraints)`
`3168`	`3170`	`{`
`3169`	`3171`	`DomainConstraintStatecon= (DomainConstraintState)lfirst(l);`
`3170`		`-Datum*domainval=NULL;`
`3171`		`-bool*domainnull=NULL;`
`3172`	`3172`	`Datum*save_innermost_domainval;`
`3173`	`3173`	`bool*save_innermost_domainnull;`
`3174`	`3174`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit16a5677

File tree

1 file changed

1 file changed

`‎src/backend/executor/execExpr.c`

0 commit comments