Commit1699125

Etsuro Fujita

committed

Correct error message for row-level triggers with transition tables on partitioned tables.

"Triggers on partitioned tables cannot have transition tables." isincorrect as we allow statement-level triggers on partitioned tables tohave transition tables.This has been wrong since commit86f5759; back-patch to v11 where thatcommit came in.Reviewed by Tom Lane.Discussion:https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

1 parent18865f4 commit1699125Copy full SHA for 1699125

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ CreateTriggerFiringOn(CreateTrigStmt stmt, const char queryString,`
`249`	`249`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`250`	`250`	`errmsg("\"%s\" is a partitioned table",`
`251`	`251`	`RelationGetRelationName(rel)),`
`252`		`-errdetail("Triggers on partitionedtablescannot have transition tables.")));`
	`252`	`+errdetail("ROW triggers with transitiontablesare not supported on partitioned tables.")));`
`253`	`253`	`}`
`254`	`254`	`}`
`255`	`255`	`elseif (rel->rd_rel->relkind==RELKIND_VIEW)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2020,7 +2020,7 @@ create trigger failed after update on parted_trig`
`2020`	`2020`	`referencing old table as old_table`
`2021`	`2021`	`for each row execute procedure trigger_nothing();`
`2022`	`2022`	`ERROR: "parted_trig" is a partitioned table`
`2023`		`-DETAIL:Triggers on partitionedtablescannot have transition tables.`
	`2023`	`+DETAIL:ROW triggers with transitiontablesare not supported on partitioned tables.`
`2024`	`2024`	`drop table parted_trig;`
`2025`	`2025`	`--`
`2026`	`2026`	`-- Verify trigger creation for partitioned tables, and drop behavior`

Comments

(0)