NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit1676e43

committed

Fix brin regression test so it actually tests cidr.

The problem noted in my previous commit was simpler than I thought:we weren't getting an index plan because the column wasn't indexed.

1 parent79454c6 commit1676e43Copy full SHA for 1676e43

File tree

2 files changed

-28

lines changed

src/test/regress
- expected
  - brin.out
- sql
  - brin.sql

2 files changed

-28

lines changed

`‎src/test/regress/expected/brin.out`

Lines changed: 2 additions & 28 deletions

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,8 @@ CREATE INDEX brinidx ON brintest USING brin (`
`77`	`77`	`macaddrcol,`
`78`	`78`	`inetcol inet_inclusion_ops,`
`79`	`79`	`inetcol inet_minmax_ops,`
	`80`	`+cidrcol inet_inclusion_ops,`
	`81`	`+cidrcol inet_minmax_ops,`
`80`	`82`	`bpcharcol,`
`81`	`83`	`datecol,`
`82`	`84`	`timecol,`
`@@ -373,34 +375,6 @@ BEGIN`
`373`	`375`	`END LOOP;`
`374`	`376`	`END;`
`375`	`377`	`$x$;`
`376`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,&&,inet,10/8,100)`
`377`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,=,inet,10.2.14/24,2)`
`378`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<,inet,255.255.255.255,100)`
`379`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<=,inet,255.255.255.255,100)`
`380`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>,inet,0.0.0.0,125)`
`381`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>=,inet,0.0.0.0,125)`
`382`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>>=,inet,10.2.14.231/24,2)`
`383`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>>,inet,10.2.14.231/25,2)`
`384`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<<=,inet,10.2.14.231/8,100)`
`385`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<<,inet,0/0,100)`
`386`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,&&,inet,fe80::6e40:8ff:fea9:a673/32,25)`
`387`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>>=,inet,fe80::6e40:8ff:fea9:8c46,1)`
`388`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<<=,inet,fe80::6e40:8ff:fea9:a673/32,25)`
`389`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,=,inet,fe80::6e40:8ff:fea9:8c46,1)`
`390`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,&&,cidr,10/8,100)`
`391`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,=,cidr,10.2.14/24,2)`
`392`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<,cidr,255.255.255.255,100)`
`393`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<=,cidr,255.255.255.255,100)`
`394`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>,cidr,0.0.0.0,125)`
`395`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>=,cidr,0.0.0.0,125)`
`396`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>>=,cidr,10.2.14/24,2)`
`397`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>>,cidr,10.2.14/25,2)`
`398`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<<=,cidr,10/8,100)`
`399`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<<,cidr,0/0,100)`
`400`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,&&,cidr,fe80::/32,25)`
`401`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,>>=,cidr,fe80::6e40:8ff:fea9:8c46,1)`
`402`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,<<=,cidr,fe80::/32,25)`
`403`		`-WARNING: did not get bitmap indexscan plan for (cidrcol,=,cidr,fe80::6e40:8ff:fea9:8c46,1)`
`404`	`378`	`INSERT INTO brintest SELECT`
`405`	`379`	`repeat(stringu1, 42)::bytea,`
`406`	`380`	`substr(stringu1, 1, 1)::"char",`

`‎src/test/regress/sql/brin.sql`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,8 @@ CREATE INDEX brinidx ON brintest USING brin (`
`80`	`80`	`macaddrcol,`
`81`	`81`	`inetcol inet_inclusion_ops,`
`82`	`82`	`inetcol inet_minmax_ops,`
	`83`	`+cidrcol inet_inclusion_ops,`
	`84`	`+cidrcol inet_minmax_ops,`
`83`	`85`	`bpcharcol,`
`84`	`86`	`datecol,`
`85`	`87`	`timecol,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1676e43

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/brin.out`

`‎src/test/regress/sql/brin.sql`

0 commit comments