Commit1671c01

committed

Remove repeated test in contrib/amcheck

Repeating these tests adds unnecessary cycles, since no improvement intest coverage is expected.Cleanup from commit8224de4.Peter Geoghegan

1 parent9d0383c commit1671c01Copy full SHA for 1671c01

File tree

-24

lines changed

-24

lines changed

Lines changed: 1 addition & 19 deletions

Original file line number	Diff line number	Diff line change
`@@ -111,27 +111,9 @@ SELECT bt_index_parent_check('bttest_multi_idx', true);`
`111`	`111`
`112`	`112`	`(1 row)`
`113`	`113`
`114`		`-SELECT bt_index_parent_check('bttest_multi_idx', true);`
`115`		`- bt_index_parent_check`
`116`		`------------------------`
`117`		`-`
`118`		`-(1 row)`
`119`		`-`
`120`		`--- repeat same checks with index made by insertions`
	`114`	`+-- repeat expansive test for index built using insertions`
`121`	`115`	`TRUNCATE bttest_multi;`
`122`	`116`	`INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i;`
`123`		`-SELECT bt_index_check('bttest_multi_idx');`
`124`		`- bt_index_check`
`125`		`-----------------`
`126`		`-`
`127`		`-(1 row)`
`128`		`-`
`129`		`-SELECT bt_index_parent_check('bttest_multi_idx', true);`
`130`		`- bt_index_parent_check`
`131`		`------------------------`
`132`		`-`
`133`		`-(1 row)`
`134`		`-`
`135`	`117`	`SELECT bt_index_parent_check('bttest_multi_idx', true);`
`136`	`118`	`bt_index_parent_check`
`137`	`119`	`-----------------------`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -65,15 +65,11 @@ COMMIT;`
`65`	`65`	`SELECT bt_index_check('bttest_multi_idx');`
`66`	`66`	`-- more expansive test for index with included columns`
`67`	`67`	`SELECT bt_index_parent_check('bttest_multi_idx', true);`
`68`		`-SELECT bt_index_parent_check('bttest_multi_idx', true);`
`69`	`68`
`70`		`--- repeatsame checks with indexmade by insertions`
	`69`	`+-- repeatexpansive test for indexbuilt using insertions`
`71`	`70`	`TRUNCATE bttest_multi;`
`72`	`71`	`INSERT INTO bttest_multiSELECT i, i%2FROM generate_series(1,100000)as i;`
`73`		`-SELECT bt_index_check('bttest_multi_idx');`
`74`	`72`	`SELECT bt_index_parent_check('bttest_multi_idx', true);`
`75`		`-SELECT bt_index_parent_check('bttest_multi_idx', true);`
`76`		`-`
`77`	`73`
`78`	`74`	`-- cleanup`
`79`	`75`	`DROPTABLE bttest_a;`

Comments

(0)